Changeset 88519 in vbox for trunk/src/VBox

Timestamp:

Apr 15, 2021 10:20:22 AM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:8161: A bit of rework for VirtualBox Manager; Saving geometry instantly on change to avoid doing that on app shutdown.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIVirtualBoxManager.cpp (modified) (5 diffs)
• UIVirtualBoxManager.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManager.cpp

@@ -467 +467 @@
     , m_fFirstMediumEnumerationHandled(false)
     , m_pActionPool(0)
+    , m_iGeometrySaveTimerId(-1)
 {
     s_pInstance = this;
@@ -537 +538 @@
             emit sigWindowRemapped();
             break;
+        }
+        /* Handle move/resize geometry changes: */
+        case QEvent::Move:
+        case QEvent::Resize:
+        {
+            if (m_iGeometrySaveTimerId != -1)
+                killTimer(m_iGeometrySaveTimerId);
+            m_iGeometrySaveTimerId = startTimer(300);
+            break;
+        }
+        /* Handle timer event started above: */
+        case QEvent::Timer:
+        {
+            QTimerEvent *pTimerEvent = static_cast<QTimerEvent*>(pEvent);
+            if (pTimerEvent->timerId() == m_iGeometrySaveTimerId)
+            {
+                killTimer(m_iGeometrySaveTimerId);
+                m_iGeometrySaveTimerId = -1;
+                const QRect geo = currentGeometry();
+                LogRel2(("GUI: UIVirtualBoxManager: Saving geometry as: Origin=%dx%d, Size=%dx%d\n",
+                         geo.x(), geo.y(), geo.width(), geo.height()));
+                gEDataManager->setSelectorWindowGeometry(geo, isCurrentlyMaximized());
+            }
         }
         default:
@@ -2254 +2278 @@
 #endif
 
-    /* Medium enumeration connections: */
+    /* UICommon connections: */
     connect(&uiCommon(), &UICommon::sigMediumEnumerationFinished,
             this, &UIVirtualBoxManager::sltHandleMediumEnumerationFinish);
@@ -2470 +2494 @@
 }
 
-void UIVirtualBoxManager::saveSettings()
-{
-    /* Save window geometry: */
-    {
-        const QRect geo = currentGeometry();
-        LogRel2(("GUI: UIVirtualBoxManager: Saving geometry as: Origin=%dx%d, Size=%dx%d\n",
-                 geo.x(), geo.y(), geo.width(), geo.height()));
-        gEDataManager->setSelectorWindowGeometry(geo, isCurrentlyMaximized());
-    }
-}
-
 void UIVirtualBoxManager::cleanupConnections()
 {
@@ -2517 +2530 @@
     sltCloseManagerWindow(UIToolType_Cloud);
     sltCloseManagerWindow(UIToolType_CloudConsole);
-
-    /* Save settings: */
-    saveSettings();
 
     /* Cleanup: */

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManager.h

@@ -321 +321 @@
         void loadSettings();
 
-        /** Saves settings. */
-        void saveSettings();
         /** Cleanups connections. */
         void cleanupConnections();
@@ -458 +456 @@
     /** Holds the central-widget instance. */
     UIVirtualBoxManagerWidget *m_pWidget;
+
+    /** Holds the geometry save timer ID. */
+    int  m_iGeometrySaveTimerId;
 };