Changeset 88527 in vbox for trunk/src/VBox/Installer/darwin

Timestamp:

Apr 15, 2021 11:46:26 AM (4 years ago)

Author:

vboxsync

Message:

Autostart/darwin: As part of shell script best practices enclose variable
references with double quotes to prevent reinterpretation of any special
characters within the quoted string. Observed when investigating
Linux autostart-service.sh issues in bugref:9987.

File:

• trunk/src/VBox/Installer/darwin/VirtualBox/VBoxAutostartDarwin.sh (modified) (2 diffs)

trunk/src/VBox/Installer/darwin/VirtualBox/VBoxAutostartDarwin.sh

@@ -24 +24 @@
     for user in `dscl . -list /Users`
     do
-        HOMEDIR=`dscl . -read /Users/${user} | grep NFSHomeDirectory | sed 's/NFSHomeDirectory: //g'`
-        USERSHELL=`dscl . -read /Users/${user} | grep UserShell | sed 's/UserShell: //g'`
+        HOMEDIR=`dscl . -read /Users/"${user}" NFSHomeDirectory | sed 's/NFSHomeDirectory: //g'`
+        USERSHELL=`dscl . -read /Users/"${user}" UserShell | sed 's/UserShell: //g'`
 
         # Check for known home directories and shells for daemons
@@ -37 +37 @@
             start)
                 # Start the daemon
-                su ${user} -c "/Applications/VirtualBox.app/Contents/MacOS/VBoxAutostart --quiet --start --background --config ${CONFIG}"
+                su "${user}" -c "/Applications/VirtualBox.app/Contents/MacOS/VBoxAutostart --quiet --start --background --config ${CONFIG}"
                 ;;
             stop)
-                # Start the daemon
-                su ${user} -c "/Applications/VirtualBox.app/Contents/MacOS/VBoxAutostart --quiet --stop --config ${CONFIG}"
+                # Stop the daemon
+                su "${user}" -c "/Applications/VirtualBox.app/Contents/MacOS/VBoxAutostart --quiet --stop --config ${CONFIG}"
                 ;;
                *)