Changeset 88540 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Apr 15, 2021 12:56:11 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

143818

Message:

FE/Qt: bugref:8161: A bit of rework for Tools pane; Saving last chosen global and machine items instantly on change to avoid doing that on app shutdown.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools

Files:

• UIToolsModel.cpp (modified) (6 diffs)
• UIToolsModel.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsModel.cpp

@@ -74 +74 @@
 void UIToolsModel::init()
 {
-    /* Load last selected item: */
-    loadLastSelectedItems();
+    /* Load settings: */
+    loadSettings();
 
     /* Update linked values: */
@@ -218 +218 @@
             default: break;
         }
+
+        /* Save selected items data: */
+        const QList<UIToolType> set = QList<UIToolType>() << m_pLastItemGlobal->itemType() << m_pLastItemMachine->itemType();
+        LogRel2(("GUI: UIToolsModel: Saving tool items as: Global=%d, Machine=%d\n",
+                 (int)m_pLastItemGlobal->itemType(), (int)m_pLastItemMachine->itemType()));
+        gEDataManager->setToolsPaneLastItemsChosen(set);
     }
     /* Otherwise reset current item: */
@@ -556 +562 @@
 }
 
-void UIToolsModel::loadLastSelectedItems()
+void UIToolsModel::loadSettings()
 {
     /* Load selected items data: */
     const QList<UIToolType> data = gEDataManager->toolsPaneLastItemsChosen();
-
-    /* First of them is current global class item definition: */
     UIToolType enmTypeGlobal = data.value(0);
     if (!UIToolStuff::isTypeOfClass(enmTypeGlobal, UIToolClass_Global))
         enmTypeGlobal = UIToolType_Welcome;
+    UIToolType enmTypeMachine = data.value(1);
+    if (!UIToolStuff::isTypeOfClass(enmTypeMachine, UIToolClass_Machine))
+        enmTypeMachine = UIToolType_Details;
+    LogRel2(("GUI: UIToolsModel: Restoring tool items as: Global=%d, Machine=%d\n",
+             (int)enmTypeGlobal, (int)enmTypeMachine));
+
+    /* First of them is current global class item definition: */
     foreach (UIToolsItem *pItem, items())
         if (pItem->itemType() == enmTypeGlobal)
@@ -572 +583 @@
 
     /* Second of them is current machine class item definition: */
-    UIToolType enmTypeMachine = data.value(1);
-    if (!UIToolStuff::isTypeOfClass(enmTypeMachine, UIToolClass_Machine))
-        enmTypeMachine = UIToolType_Details;
     foreach (UIToolsItem *pItem, items())
         if (pItem->itemType() == enmTypeMachine)
@@ -582 +590 @@
 }
 
-void UIToolsModel::saveLastSelectedItems()
-{
-    /* Prepare selected items data: */
-    const QList<UIToolType> set = QList<UIToolType>() << m_pLastItemGlobal->itemType() << m_pLastItemMachine->itemType();
-
-    /* Save selected items data: */
-    gEDataManager->setToolsPaneLastItemsChosen(set);
-}
-
 void UIToolsModel::cleanupConnections()
 {
@@ -623 +622 @@
 void UIToolsModel::cleanup()
 {
-    /* Save last selected item: */
-    saveLastSelectedItems();
     /* Cleanup connections: */
     cleanupConnections();

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsModel.h

@@ -223 +223 @@
         /** Prepares connections. */
         void prepareConnections();
-        /** Loads last selected items. */
-        void loadLastSelectedItems();
-
-        /** Saves last selected items. */
-        void saveLastSelectedItems();
+        /** Loads settings. */
+        void loadSettings();
+
         /** Cleanups connections. */
         void cleanupConnections();