Changeset 88543 in vbox for trunk/src/VBox

Timestamp:

Apr 15, 2021 1:02:17 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

143821

Message:

NAT: slirp_ext_m_get - assertions are nice, but make sure we actually
fail in the release build too if the asserted condition is false.
bugref:9991.

File:

• trunk/src/VBox/Devices/Network/slirp/misc.c (modified) (2 diffs)

trunk/src/VBox/Devices/Network/slirp/misc.c

@@ -500 +500 @@
     LogFlowFunc(("ENTER: cbMin:%d, ppvBuf:%p, pcbBuf:%p\n", cbMin, ppvBuf, pcbBuf));
 
+    *ppvBuf = NULL;
+    *pcbBuf = 0;
+
     if (cbMin < MCLBYTES)
         size = MCLBYTES;
@@ -507 +510 @@
         size = MJUM16BYTES;
     else
-        AssertMsgFailed(("Unsupported size"));
+    {
+        AssertMsgFailed(("Unsupported size %zu", cbMin));
+        LogFlowFunc(("LEAVE: NULL (bad size %zu)\n", cbMin));
+        return NULL;
+    }
 
     m = m_getjcl(pData, M_NOWAIT, MT_HEADER, M_PKTHDR, size);
     if (m == NULL)
     {
-        *ppvBuf = NULL;
-        *pcbBuf = 0;
         LogFlowFunc(("LEAVE: NULL\n"));
         return NULL;