Changeset 88586 in vbox for trunk/src/VBox/Frontends

Timestamp:

Apr 19, 2021 4:40:07 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:8161: More rework for Chooser pane; Save group definition changes even after group toggling; That allows to avoid saving on app shutdown.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser

Files:

• UIChooserAbstractModel.cpp (modified) (6 diffs)
• UIChooserAbstractModel.h (modified) (2 diffs)
• UIChooserItemGroup.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserAbstractModel.cpp

@@ -403 +403 @@
 void UIChooserAbstractModel::deinit()
 {
-    // WORKAROUND:
-    // Currently we are not saving group descriptors
-    // (which reflecting group toggle-state) on-the-fly,
-    // so for now we are additionally save group definitions
-    // when exiting application:
-    saveGroupDefinitions();
-
     /* Make sure all saving steps complete: */
     makeSureGroupSettingsSaveIsFinished();
@@ -540 +533 @@
 void UIChooserAbstractModel::saveGroups()
 {
-    emit sigStartGroupSaving();
+    emit sigSaveSettings();
 }
 
@@ -987 +980 @@
 }
 
-void UIChooserAbstractModel::sltStartGroupSaving()
+void UIChooserAbstractModel::sltSaveSettings()
 {
     saveGroupSettings();
@@ -1000 +993 @@
 void UIChooserAbstractModel::prepareConnections()
 {
-    /* Cloud VM registration connections: */
+    /* UICommon connections: */
     connect(&uiCommon(), &UICommon::sigCloudMachineUnregistered,
             this, &UIChooserAbstractModel::sltCloudMachineUnregistered);
@@ -1032 +1025 @@
             this, &UIChooserAbstractModel::sltHandleCloudProviderUninstall);
 
-    /* Group saving connections: */
-    connect(this, &UIChooserAbstractModel::sigStartGroupSaving,
-            this, &UIChooserAbstractModel::sltStartGroupSaving,
+    /* Settings saving connections: */
+    connect(this, &UIChooserAbstractModel::sigSaveSettings,
+            this, &UIChooserAbstractModel::sltSaveSettings,
             Qt::QueuedConnection);
 
@@ -1076 +1069 @@
                this, &UIChooserAbstractModel::sltHandleCloudProviderUninstall);
 
-    /* Group saving connections: */
-    disconnect(this, &UIChooserAbstractModel::sigStartGroupSaving,
-               this, &UIChooserAbstractModel::sltStartGroupSaving);
+    /* Settings saving connections: */
+    disconnect(this, &UIChooserAbstractModel::sigSaveSettings,
+               this, &UIChooserAbstractModel::sltSaveSettings);
 
     /* Extra-data connections: */

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserAbstractModel.h

@@ -57 +57 @@
     /** @name Group saving stuff.
       * @{ */
-        /** Commands to start group saving. */
-        void sigStartGroupSaving();
+        /** Issues request to save settings. */
+        void sigSaveSettings();
         /** Notifies listeners about group saving state changed. */
         void sigGroupSavingStateChanged();
@@ -236 +236 @@
     /** @name Group saving stuff.
       * @{ */
-        /** Handles request to start group saving. */
-        void sltStartGroupSaving();
+        /** Handles request to save settings. */
+        void sltSaveSettings();
     /** @} */
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItemGroup.cpp

@@ -1032 +1032 @@
     /* Repaint finally: */
     update();
+    /* Save changes: */
+    model()->saveGroups();
 
     /* Toggle finished: */