Changeset 88716 in vbox

Timestamp:

Apr 26, 2021 8:41:51 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144033

Message:

linux/vboxsf: Document 5.10+ adjustments. We cannot provide both regular and iterative read/write methods because the kernel thinks there might be semantics differences and refuses to do in-kernel reads/writes to our FS. For in-kernel reads/writes there must only be .write_iter/.read_iter now. Restored removed newlines (fingers off my newlines). Rebalanced newlines (multi-function #ifdefs have newline before and after). bugref:9994

File:

• trunk/src/VBox/Additions/linux/sharedfolders/regops.c (modified) (7 diffs)

trunk/src/VBox/Additions/linux/sharedfolders/regops.c

@@ -1467 +1467 @@
 }
 
-
-#if RTLNX_VER_MAX(5,10,0)
+#if RTLNX_VER_MAX(5,10,0) /* No regular .read/.write for 5.10, only .read_iter/.write_iter or in-kernel reads/writes fail. */
+
 /**
  * Read function used when accessing files that are memory mapped.
@@ -1627 +1627 @@
 }
 
+
 /**
  * Read from a regular file.
@@ -1725 +1726 @@
     return vbsf_reg_read_locking(file, buf, size, off, pSuperInfo, sf_r);
 }
+
 #endif /* < 5.10.0 */
-
 
 /**
@@ -1814 +1815 @@
 }
 
-
-#if RTLNX_VER_MAX(5,10,0)
+#if RTLNX_VER_MAX(5,10,0) /* No regular .read/.write for 5.10, only .read_iter/.write_iter or in-kernel reads/writes fail. */
+
 /**
  * Fallback case of vbsf_reg_write() that locks the user buffers and let the host
@@ -1942 +1943 @@
     return cbRet;
 }
+
 
 /**
@@ -2079 +2081 @@
     return vbsf_reg_write_locking(file, buf, size, off, pos, inode, sf_i, pSuperInfo, sf_r);
 }
+
 #endif /* < 5.10.0 */
-
 #if RTLNX_VER_MIN(2,6,19)
 
@@ -3508 +3510 @@
 struct file_operations vbsf_reg_fops = {
     .open            = vbsf_reg_open,
-#if RTLNX_VER_MAX(5,10,0)
+#if RTLNX_VER_MAX(5,10,0) /* No regular .read/.write for 5.10, only .read_iter/.write_iter or in-kernel reads/writes fail. */
     .read            = vbsf_reg_read,
     .write           = vbsf_reg_write,