Changeset 88790 in vbox

Timestamp:

Apr 30, 2021 7:45:05 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144123

Message:

Intel IOMMU: bugref:9967 Queued Invalidation WIP.

File:

• trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp

@@ -1239 +1239 @@
                 {
                     /* Verify table translation mode is legacy. */
-                    uint8_t const  fTtm = RT_BF_GET(pThis->uRtaddrReg, VTD_BF_RTADDR_REG_TTM);
+                    uint8_t const fTtm = RT_BF_GET(pThis->uRtaddrReg, VTD_BF_RTADDR_REG_TTM);
                     if (fTtm == VTD_TTM_LEGACY_MODE)
                     {
@@ -1693 +1693 @@
 
                 /* Paranoia. */
-                Assert(cbQueue <= cbMaxQs); NOREF(cbMaxQs);
+                Assert(cbQueue <= cbMaxQs);
                 Assert(!(offQueueTail & ~VTD_IQT_REG_RW_MASK));
                 Assert(!(offQueueHead & ~VTD_IQH_REG_RW_MASK));
@@ -1756 +1756 @@
                         /*
                          * We've processed all requests and the lock shouldn't be held at this point.
-                         * Instead of re-acquiring the lock just to release it again and go back to
-                         * the thread loop using 'continue' here. It's a bit ugly but it certainly
+                         * Using 'continue' here allows us to skip re-acquiring the lock just to release
+                         * it again before going back to the thread loop. It's a bit ugly but it certainly
                          * helps with performance.
                          */