Changeset 88842 in vbox for trunk/src/VBox/Devices/Bus

Timestamp:

May 3, 2021 4:50:40 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144176

Message:

Intel IOMMU: bugref:9967 Release build fix and comment nit.

File:

• trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp

@@ -1328 +1328 @@
 {
     /* At present, we only care about the low 32-bits, high 32-bits are data. */
-    Assert(offReg == VTD_MMIO_OFF_IQA_REG);
+    Assert(offReg == VTD_MMIO_OFF_IQA_REG); NOREF(offReg);
 
     /** @todo What happens if IQA_REG is written when dmarInvQueueCanProcessRequests
@@ -1877 +1877 @@
     PCDMAR      pThis   = PDMDEVINS_2_DATA(pDevIns, PDMAR);
     PCDMARR3    pThisR3 = PDMDEVINS_2_DATA_CC(pDevIns, PCDMARR3);
-    PCPDMPCIDEV pPciDev = pDevIns->apPciDevs[0];
-    PDMPCIDEV_ASSERT_VALID(pDevIns, pPciDev);
-
     bool const fVerbose = RTStrCmp(pszArgs, "verbose") == 0;
 
     /*
-     * We lock the device to get a consistent register state, but it is
-     * ASSUMED pHlp->pfnPrintf is expensive, so we copy the registers into
-     * temporaries and release the lock ASAP.
+     * We lock the device to get a consistent register state as it is
+     * ASSUMED pHlp->pfnPrintf is expensive, so we copy the registers (the
+     * ones we care about here) into temporaries and release the lock ASAP.
      *
      * Order of register being read and outputted is in accordance with the