Changeset 88889 in vbox for trunk/src/VBox/Devices

Timestamp:

May 6, 2021 12:47:10 AM (4 years ago)

Author:

vboxsync

Message:

AudioMixBuffer: Fixed bug in AudioMixBufPeekResampling where we'd poentially overflow the output buffer. bugref:9890

File:

• trunk/src/VBox/Devices/Audio/AudioMixBuffer.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/AudioMixBuffer.cpp

@@ -2035 +2035 @@
         /* Rate conversion into temporary buffer. */
         int64_t  ai64DstRate[1024];
-        uint32_t cSrcFrames = RT_MIN(pMixBuf->cFrames - offSrcFrame, cMaxSrcFrames);
-        uint32_t const cDstFrames = pState->Rate.pfnResample(ai64DstRate, RT_ELEMENTS(ai64DstRate) / pState->cDstChannels,
+        uint32_t cSrcFrames    = RT_MIN(pMixBuf->cFrames - offSrcFrame, cMaxSrcFrames);
+        uint32_t cMaxDstFrames = RT_MIN(RT_ELEMENTS(ai64DstRate) / pState->cDstChannels, cbDst / pState->cbDstFrame);
+        uint32_t const cDstFrames = pState->Rate.pfnResample(ai64DstRate, cMaxDstFrames,
                                                             &pMixBuf->pFrames[offSrcFrame].i64LSample, cSrcFrames, &cSrcFrames,
                                                             &pState->Rate);