Changeset 88891 in vbox

Timestamp:

May 6, 2021 12:53:17 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144226

Message:

DrvAudio: A couple of todos and logging. bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -3032 +3032 @@
      */
     uint32_t cbWritable = 0;
+    DRVAUDIOPLAYSTATE const enmPlayMode = pStreamEx->Out.enmPlayState;
     if (   PDMAudioStrmStatusCanWrite(pStreamEx->fStatus)
         && pThis->pHostDrvAudio != NULL)
     {
-        switch (pStreamEx->Out.enmPlayState)
+        switch (enmPlayMode)
         {
             /*
@@ -3093 +3094 @@
 
             case DRVAUDIOPLAYSTATE_NOPLAY:
+/** @todo we'll return zero here. but what if the device was
+ * reactivate/whatever.  We won't get to the play code that detects that
+ * state change and we end up playing nothing...  Probably holding up both
+ * this and other output streams / driver chains. */
                 break;
             case DRVAUDIOPLAYSTATE_INVALID:
@@ -3105 +3110 @@
 
     RTCritSectLeave(&pThis->CritSect);
-    Log3Func(("[%s] cbWritable=%RU32 (%RU64ms)\n",
-              pStreamEx->Core.szName, cbWritable, PDMAudioPropsBytesToMilli(&pStreamEx->Host.Cfg.Props, cbWritable)));
+    Log3Func(("[%s] cbWritable=%RU32 (%RU64ms) enmPlayMode=%s\n", pStreamEx->Core.szName, cbWritable,
+              PDMAudioPropsBytesToMilli(&pStreamEx->Host.Cfg.Props, cbWritable), drvAudioPlayStateName(enmPlayMode) ));
     return cbWritable;
 }
@@ -3303 +3308 @@
              * Get the backend state and check if it changed.
              */
+/** @todo This is the wrong place for doing this, or we need to do it in more places.  Problem is that if we've
+ * entered NOPLAY mode this function won't get called because StreamGetWritable returns zero. A bit difficult to
+ * reproduce, though. */
             PDMHOSTAUDIOSTREAMSTATE const enmBackendState = drvAudioStreamGetBackendState(pThis, pStreamEx);
             if (enmBackendState == pStreamEx->enmLastBackendState)