Changeset 88899 in vbox for trunk/src/VBox/Devices

Timestamp:

May 6, 2021 12:37:27 PM (4 years ago)

Author:

vboxsync

Message:

DevIchAc97, DevSB16: For the last time, RTStrPrintf doesn't work like that and shouldn't be used instead of RTStrCopy! bugref:9890

Location:

trunk/src/VBox/Devices/Audio

Files:

• DevIchAc97.cpp (modified) (1 diff)
• DevSB16.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -1855 +1855 @@
         return VERR_NO_MEMORY;
 
-    if (!RTStrPrintf(pStreamCfg->szName, sizeof(pStreamCfg->szName), "%s", pCfg->szName))
-    {
-        PDMAudioStrmCfgFree(pStreamCfg);
-        return VERR_BUFFER_OVERFLOW;
-    }
+    AssertCompile(sizeof(pStreamCfg->szName) == sizeof(pCfg->szName));
+    RTStrCopy(pStreamCfg->szName, sizeof(pStreamCfg->szName), pCfg->szName);
 
     LogFunc(("[LUN#%RU8] %s\n", pDrv->uLUN, pStreamCfg->szName));

trunk/src/VBox/Devices/Audio/DevSB16.cpp

@@ -1990 +1990 @@
         return VERR_NO_MEMORY;
 
-    if (!RTStrPrintf(pStreamCfg->szName, sizeof(pStreamCfg->szName), "%s", pCfg->szName))
-    {
-        PDMAudioStrmCfgFree(pStreamCfg);
-        return VERR_BUFFER_OVERFLOW;
-    }
+    AssertCompile(sizeof(pStreamCfg->szName) == sizeof(pCfg->szName));
+    RTStrCopy(pStreamCfg->szName, sizeof(pStreamCfg->szName), pCfg->szName);
 
     LogFunc(("[LUN#%RU8] %s\n", pDrv->uLUN, pStreamCfg->szName));