Changeset 8894 in vbox for trunk/src/VBox/Frontends

Timestamp:

May 16, 2008 1:05:23 PM (17 years ago)

Author:

vboxsync

Message:

2854: "Warn if not enough guest VRAM when entering fullscreen with Additions (and AutoResize) enabled" implemented.

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• include/VBoxConsoleView.h (modified) (1 diff)
• include/VBoxProblemReporter.h (modified) (1 diff)
• src/VBoxConsoleView.cpp (modified) (1 diff)
• src/VBoxConsoleWnd.cpp (modified) (2 diffs)
• src/VBoxProblemReporter.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/include/VBoxConsoleView.h

@@ -104 +104 @@
     QRect getDesktopGeometry();
 
+    bool isAutoresizeGuestActive();
+
 signals:
 

trunk/src/VBox/Frontends/VirtualBox/include/VBoxProblemReporter.h

@@ -183 +183 @@
     void cannotFindMachineByName (const CVirtualBox &vbox, const QString &name);
 
-    void cannotEnterSeamlessMode (ULONG aWidth, ULONG aHeight, ULONG aBpp, ULONG64 aMinVRAM);
+    void cannotEnterFSMode (bool aIsSeamless, ULONG aWidth, ULONG aHeight,
+                            ULONG aBpp, ULONG64 aMinVRAM);
 
     bool confirmMachineDeletion (const CMachine &machine);

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp

@@ -2304 +2304 @@
 }
 
+bool VBoxConsoleView::isAutoresizeGuestActive()
+{
+    return mIsAdditionsActive && mAutoresizeGuest;
+}
+
 /**
  *  Called on every key press and release (while in focus).

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleWnd.cpp

@@ -1976 +1976 @@
 {
     disconnect (console, SIGNAL (resizeHintDone()), 0, 0);
-    if (aSeamless)
-    {
-        /* Check if the Guest Video RAM enough for the seamless mode. */
-        QRect screen = QApplication::desktop()->availableGeometry (this);
+    /* Check if the Guest Video RAM enough for the fullscreen/seamless mode. */
+    if (aSeamless || console->isAutoresizeGuestActive())
+    {
+        QRect screen = aSeamless ?
+            QApplication::desktop()->availableGeometry (this) :
+            QApplication::desktop()->screenGeometry (this);
         ULONG64 availBits = csession.GetMachine().GetVRAMSize() /* vram */
                           * _1M /* mb to bytes */
@@ -1993 +1995 @@
         if (aOn && (availBits < usedBits))
         {
-            vboxProblem().cannotEnterSeamlessMode (screen.width(),
+            vboxProblem().cannotEnterFSMode (aSeamless, screen.width(),
                 screen.height(), guestBpp, (((usedBits + 7) / 8 + _1M - 1) / _1M) * _1M);
             return false;

trunk/src/VBox/Frontends/VirtualBox/src/VBoxProblemReporter.cpp

@@ -933 +933 @@
 }
 
-void VBoxProblemReporter::cannotEnterSeamlessMode (ULONG /* aWidth */,
-                                                   ULONG /* aHeight */,
-                                                   ULONG /* aBpp */,
-                                                   ULONG64 aMinVRAM)
+void VBoxProblemReporter::cannotEnterFSMode (bool aIsSeamless,
+                                             ULONG /* aWidth */,
+                                             ULONG /* aHeight */,
+                                             ULONG /* aBpp */,
+                                             ULONG64 aMinVRAM)
 {
     message (&vboxGlobal().consoleWnd(), Error,
-             tr ("<p>Could not enter seamless mode due to insufficient guest "
+             tr ("<p>Could not enter %1 due to insufficient guest "
                  "video memory.</p>"
-                 "<p>You should configure the VM to have at least <b>%1</b> "
+                 "<p>You should configure the VM to have at least <b>%2</b> "
                  "of video memory.</p>")
+             .arg (aIsSeamless ? tr ("seamless mode") : tr ("fullscreen mode"))
              .arg (VBoxGlobal::formatSize (aMinVRAM)));
 }