Changeset 89131 in vbox

Timestamp:

May 17, 2021 11:55:04 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144472

Message:

DrvAudio: Fixed missing VINF_SUCCESS indicators in some DRAIN command paths. Log byte counts/offset as hex (easier to see stereo misalignments in hex among other things). bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -2673 +2673 @@
                             pStreamEx->fStatus |= PDMAUDIOSTREAM_STS_PENDING_DISABLE;
                             PDMAUDIOSTREAM_STS_ASSERT_VALID(pStreamEx->fStatus);
+                            rc = VINF_SUCCESS;
                             break;
                         }
@@ -2712 +2713 @@
                         pStreamEx->fStatus |= PDMAUDIOSTREAM_STS_PENDING_DISABLE;
                         PDMAUDIOSTREAM_STS_ASSERT_VALID(pStreamEx->fStatus);
+                        rc = VINF_SUCCESS;
                         break;
 
@@ -3191 +3193 @@
 
     RTCritSectLeave(&pThis->CritSect);
-    Log3Func(("[%s] cbReadable=%RU32 (%RU64ms)\n",
+    Log3Func(("[%s] cbReadable=%#RX32 (%RU64ms)\n",
               pStreamEx->Core.szName, cbReadable, PDMAudioPropsBytesToMilli(&pStreamEx->Host.Cfg.Props, cbReadable)));
     return cbReadable;
@@ -3295 +3297 @@
 
     RTCritSectLeave(&pThis->CritSect);
-    Log3Func(("[%s] cbWritable=%RU32 (%RU64ms) enmPlayMode=%s enmBackendState=%s\n",
+    Log3Func(("[%s] cbWritable=%#RX32 (%RU64ms) enmPlayMode=%s enmBackendState=%s\n",
               pStreamEx->Core.szName, cbWritable, PDMAudioPropsBytesToMilli(&pStreamEx->Host.Cfg.Props, cbWritable),
               drvAudioPlayStateName(enmPlayMode), PDMHostAudioStreamStateGetName(enmBackendState) ));
@@ -3410 +3412 @@
 
     AssertMsg(PDMAudioPropsIsSizeAligned(&pStreamEx->Guest.Cfg.Props, cbBuf),
-              ("Stream '%s' got a non-frame-aligned write (%RU32 bytes)\n", pStreamEx->Core.szName, cbBuf));
+              ("Stream '%s' got a non-frame-aligned write (%#RX32 bytes)\n", pStreamEx->Core.szName, cbBuf));
 
     int rc = RTCritSectEnter(&pThis->CritSect);