Changeset 89194 in vbox

Timestamp:

May 20, 2021 9:28:17 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144535

Message:

Intel IOMMU: bugref:9967 Threading nit, better to be woken up slightly more often than missing wake ups.

File:

• trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp

@@ -263 +263 @@
     /** The event semaphore the invalidation-queue thread waits on. */
     SUPSEMEVENT                 hEvtInvQueue;
-    /** Whether the invalidation-queue thread has been signaled. */
-    bool volatile               fInvQueueThreadSignaled;
     /** Padding. */
-    bool                        afPadding0[3];
+    uint32_t                    uPadding0;
     /** Error diagnostic. */
     DMARDIAG                    enmDiag;
@@ -1058 +1056 @@
 
     if (    dmarInvQueueCanProcessRequests(pThis)
-        && !dmarInvQueueIsEmpty(pThis)
-        && !ASMAtomicXchgBool(&pThis->fInvQueueThreadSignaled, true))
-    {
-        Log4Func(("Signaling the invalidation-queue thread\n"));
+        && !dmarInvQueueIsEmpty(pThis))
+    {
+        Log4Func(("Signaling the invalidation-queue thread!!\n"));
         PDMDevHlpSUPSemEventSignal(pDevIns, pThis->hEvtInvQueue);
     }
@@ -2271 +2268 @@
          * Sleep until we are woken up.
          */
-        bool const fSignaled = ASMAtomicXchgBool(&pThis->fInvQueueThreadSignaled, false);
-        if (!fSignaled)
         {
             int const rc = PDMDevHlpSUPSemEventWaitNoResume(pDevIns, pThis->hEvtInvQueue, RT_INDEFINITE_WAIT);
@@ -2278 +2273 @@
             if (RT_UNLIKELY(pThread->enmState != PDMTHREADSTATE_RUNNING))
                 break;
-            ASMAtomicWriteBool(&pThis->fInvQueueThreadSignaled, false);
         }