Changeset 89275 in vbox for trunk/src/VBox/Devices/Bus

Timestamp:

May 25, 2021 2:59:30 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144621

Message:

Intel IOMMU: bugref:9967 Address translation, WIP.

File:

• trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp (modified) (8 diffs)

trunk/src/VBox/Devices/Bus/DevIommuIntel.cpp

@@ -143 +143 @@
 /** The current saved state version. */
 #define DMAR_SAVED_STATE_VERSION                    1
+
+/** @name DMAR_IO_PERM_XXX: DMAR I/O permissions.
+ * These are not according to the spec. other than the value of the READ and WRITE
+ * permissions. */
+#define DMAR_IO_PERM_READ                           RT_BIT(0)
+#define DMAR_IO_PERM_WRITE                          RT_BIT(1)
+#define DMAR_IO_PERM_EXECUTE                        RT_BIT(2)
+#define DMAR_IO_PERM_SUPERVISOR                     RT_BIT(3)
+/** @} */
 
 
@@ -418 +427 @@
 } DMAREVENTTYPE;
 
-
 /**
  * DMA address map.
@@ -434 +442 @@
     /** The size of the DMA access (in bytes). */
     size_t          cbDma;
+
     /** The translated system-physical address (HPA). */
     RTGCPHYS        GCPhysSpa;
@@ -1890 +1899 @@
  * @param   pDevIns         The IOMMU device instance.
  * @param   uRtaddrReg      The current RTADDR_REG value.
+ * @param   enmAddrType     The PCI memory request address type.
  * @param   pAddrRemap      The DMA address remap info.
  */
-static int dmarDrLegacyModeRemapAddr(PPDMDEVINS pDevIns, uint64_t uRtaddrReg, PDMARADDRMAP pAddrRemap)
+static int dmarDrLegacyModeRemapAddr(PPDMDEVINS pDevIns, uint64_t uRtaddrReg, PCIADDRTYPE enmAddrType, PDMARADDRMAP pAddrRemap)
 {
     uint8_t const idxRootEntry = RT_HI_U8(pAddrRemap->idDevice);
@@ -1921 +1931 @@
                             && !(uCtxEntryQword1 & ~VTD_CONTEXT_ENTRY_1_VALID_MASK))
                         {
-                            /** @todo Handle context entry validation and processing. */
-                            return VERR_NOT_IMPLEMENTED;
+                            PCDMAR pThis = PDMDEVINS_2_DATA(pDevIns, PCDMAR);
+                            uint8_t const fTt = RT_BF_GET(uCtxEntryQword0, VTD_BF_0_CONTEXT_ENTRY_TT);
+                            switch (fTt)
+                            {
+                                case 0:
+                                {
+                                    if (enmAddrType == PCIADDRTYPE_UNTRANSLATED)
+                                    {
+                                        /** @todo perform second-level translation. */
+                                        return VERR_NOT_IMPLEMENTED;
+                                    }
+                                    Log4Func(("Translation type blocks translated and translation requests\n"));
+                                    return VERR_IOMMU_ADDR_TRANSLATION_FAILED;
+                                }
+
+                                case 2:
+                                {
+                                    if (pThis->fExtCapReg & VTD_BF_ECAP_REG_PT_MASK)
+                                    {
+                                        pAddrRemap->GCPhysSpa    = pAddrRemap->uDmaAddr;
+                                        pAddrRemap->cbContiguous = pAddrRemap->cbDma;
+                                        return VINF_SUCCESS;
+                                    }
+                                    RT_FALL_THRU();
+                                }
+
+                                case 1:
+                                {
+                                    Assert(!(pThis->fExtCapReg & VTD_BF_ECAP_REG_DT_MASK));
+                                    RT_FALL_THRU();
+                                }
+
+                                default:
+                                {
+                                    dmarAtFaultQualifiedRecord(pDevIns, kDmarDiag_Atf_Lct_4_2, VTDATFAULT_LCT_4_2,
+                                                               pAddrRemap->idDevice, pAddrRemap->uDmaAddr, pAddrRemap->enmReqType,
+                                                               uCtxEntryQword0);
+                                    break;
+                                }
+                            }
                         }
                         else
                             dmarAtFaultQualifiedRecord(pDevIns, kDmarDiag_Atf_Lct_3, VTDATFAULT_LCT_3, pAddrRemap->idDevice,
-                                                       pAddrRemap->uDmaAddr, pAddrRemap->enmReqType, uCtxEntryQword0);
+                                                   pAddrRemap->uDmaAddr, pAddrRemap->enmReqType, uCtxEntryQword0);
                     }
                     else
@@ -1957 +2005 @@
  * @param   pDevIns         The IOMMU device instance.
  * @param   uRtaddrReg      The current RTADDR_REG value.
+ * @param   enmAddrType     The PCI memory request address type.
  * @param   pAddrRemap      The DMA address remap info.
  */
-static int dmarDrScalableModeRemapAddr(PPDMDEVINS pDevIns, uint64_t uRtaddrReg, PDMARADDRMAP pAddrRemap)
-{
+static int dmarDrScalableModeRemapAddr(PPDMDEVINS pDevIns, uint64_t uRtaddrReg, PCIADDRTYPE enmAddrType, PDMARADDRMAP pAddrRemap)
+{
+    RT_NOREF(enmAddrType);
     PCDMAR pThis = PDMDEVINS_2_DATA(pDevIns, PDMAR);
     if (pThis->fExtCapReg & VTD_BF_ECAP_REG_SMTS_MASK)
@@ -2056 +2106 @@
             case VTD_TTM_LEGACY_MODE:
             {
-                rc = dmarDrLegacyModeRemapAddr(pDevIns, uRtaddrReg, &AddrRemap);
+                rc = dmarDrLegacyModeRemapAddr(pDevIns, uRtaddrReg, PCIADDRTYPE_UNTRANSLATED, &AddrRemap);
                 break;
             }
@@ -2062 +2112 @@
             case VTD_TTM_SCALABLE_MODE:
             {
-                rc = dmarDrScalableModeRemapAddr(pDevIns, uRtaddrReg, &AddrRemap);
+                rc = dmarDrScalableModeRemapAddr(pDevIns, uRtaddrReg, PCIADDRTYPE_UNTRANSLATED, &AddrRemap);
                 break;
             }