Changeset 89319 in vbox for trunk/src/VBox/Frontends/VBoxAutostart

Timestamp:

May 27, 2021 1:38:13 PM (4 years ago)

Author:

vboxsync

Message:

VBoxAutostart: bugref:9341: Create "VBoxAutostart.log" release log
file in the user's vbox home directory.

Don't bother with --log* options like the posix counterpart has b/c
the user cannot change them easily anyway and is better off using
environment variables if need be.

File:

• trunk/src/VBox/Frontends/VBoxAutostart/VBoxAutostart-win.cpp (modified) (6 diffs)

trunk/src/VBox/Frontends/VBoxAutostart/VBoxAutostart-win.cpp

@@ -39 +39 @@
 #include <VBox/version.h>
 
+#include <iprt/dir.h>
 #include <iprt/env.h>
 #include <iprt/errcore.h>
@@ -80 +81 @@
 /** The service name is used for send to service main. */
 static com::Bstr g_bstrServiceName;
+
+/** Logging parameters. */
+static uint32_t      g_cHistory = 10;                   /* Enable log rotation, 10 files. */
+static uint32_t      g_uHistoryFileTime = 0;            /* No time limit, it's very low volume. */
+static uint64_t      g_uHistoryFileSize = 100 * _1M;    /* Max 100MB per file. */
 
 
@@ -289 +295 @@
     AssertMsg(fRc, ("%u\n", GetLastError())); NOREF(fRc);
     DeregisterEventSource(hEventLog);
+
+    /* write it to the release log too */
+    LogRel(("%s", pszMsg));
 }
 
@@ -979 +988 @@
 static int autostartSvcWinRunIt(int argc, char **argv)
 {
+    int rc;
+
     LogFlowFuncEnter();
 
     /*
-     * Initialize release logging.
+     * Initialize release logging, do this early.  This means command
+     * line options (like --logfile &c) can't be introduced to affect
+     * the log file parameters, but the user can't change them easily
+     * anyway and is better off using environment variables.
      */
-    /** @todo release logging of the system-wide service. */
+    do
+    {
+        char szLogFile[RTPATH_MAX];
+        rc = com::GetVBoxUserHomeDirectory(szLogFile, sizeof(szLogFile),
+                                           /* :fCreateDir */ false);
+        if (RT_FAILURE(rc))
+        {
+            autostartSvcLogError("Failed to get VirtualBox user home directory: %Rrc\n", rc);
+            break;
+        }
+
+        if (!RTDirExists(szLogFile)) /* vbox user home dir */
+        {
+            autostartSvcLogError("%s doesn't exist\n", szLogFile);
+            break;
+        }
+
+        rc = RTPathAppend(szLogFile, sizeof(szLogFile), "VBoxAutostart.log");
+        if (RT_FAILURE(rc))
+        {
+            autostartSvcLogError("Failed to construct release log file name: %Rrc\n", rc);
+            break;
+        }
+
+        rc = com::VBoxLogRelCreate("Autostart",
+                                   szLogFile,
+                                     RTLOGFLAGS_PREFIX_THREAD
+                                   | RTLOGFLAGS_PREFIX_TIME_PROG,
+                                   "all",
+                                   "VBOXAUTOSTART_RELEASE_LOG",
+                                   RTLOGDEST_FILE,
+                                   UINT32_MAX /* cMaxEntriesPerGroup */,
+                                   g_cHistory,
+                                   g_uHistoryFileTime,
+                                   g_uHistoryFileSize,
+                                   NULL);
+        if (RT_FAILURE(rc))
+            autostartSvcLogError("Failed to create release log file: %Rrc\n", rc);
+    } while (0);
+
+
 
     /*
@@ -1015 +1069 @@
                 }
                 break;
+
             default:
-                return autostartSvcDisplayGetOptError("runit", ch, &Value);
+                /**
+                 * @todo autostartSvcLogGetOptError is useless as it
+                 * is, should be change after RTGetOptPrintError.
+                 */
+                return autostartSvcLogError("RTGetOpt: %Rrc\n", ch);
         }
     }
@@ -1025 +1084 @@
         return RTEXITCODE_FAILURE;
     }
+
+    LogRel(("Starting service %ls\n", g_bstrServiceName.raw()));
 
     /*