Changeset 89369 in vbox

Timestamp:

May 28, 2021 7:03:56 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144720

Message:

FE/Qt: bugref:9831. Fixing overlay label drawing which caused recursive paint call

File:

• trunk/src/VBox/Frontends/VirtualBox/src/helpbrowser/UIHelpViewer.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/helpbrowser/UIHelpViewer.cpp

@@ -587 +587 @@
 void UIHelpViewer::resizeEvent(QResizeEvent *pEvent)
 {
-    clearOverlay();
+    if (m_fOverlayMode)
+        clearOverlay();
     /* Make sure the widget stays inside the parent during parent resize: */
     if (m_pFindInPageWidget)
@@ -686 +687 @@
     if (m_pOverlayLabel)
     {
-        if (m_fOverlayMode)
+        if (m_fOverlayMode && !m_pOverlayLabel->isVisible())
         {
             /* Scale the image to 1:1 as long as it fits into avaible space (minus some margins and scrollbar sizes): */
@@ -704 +705 @@
                        qMin(height() - vMargin, m_overlayPixmap.height()));
             m_pOverlayLabel->setPixmap(m_overlayPixmap.scaled(size,  Qt::KeepAspectRatio, Qt::SmoothTransformation));
+            m_pOverlayLabel->show();
+
             /* Center the label: */
             int x = 0.5 * (width() - vWidth - m_pOverlayLabel->width());
             int y = 0.5 * (height() - hHeight - m_pOverlayLabel->height());
             m_pOverlayLabel->move(x, y);
-            m_pOverlayLabel->show();
         }
-        else
+        if (!m_fOverlayMode && m_pOverlayLabel->isVisible())
             m_pOverlayLabel->hide();
     }