Changeset 89584 in vbox

Timestamp:

Jun 9, 2021 2:43:34 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145022

Message:

Audio/ValKit: More code for completely self-contained (self) testing. bugref:10008

Location:

trunk/src/VBox

Files:

• Devices/Audio/DrvHostAudioValidationKit.cpp (modified) (8 diffs)
• ValidationKit/utils/audio/vkatCommon.cpp (modified) (11 diffs)
• ValidationKit/utils/audio/vkatInternal.h (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DrvHostAudioValidationKit.cpp

@@ -89 +89 @@
     /** The list node. */
     RTLISTNODE             Node;
+    /** Index in test sequence (0-based). */
+    uint32_t               idxTest;
     /** Current test set entry to process. */
     PAUDIOTESTENTRY        pEntry;
@@ -122 +124 @@
     /** Current test set being handled. */
     AUDIOTESTSET        Set;
+    /** Number of total tests created. */
+    uint32_t            cTestsTotal;
     /** Number of tests in \a lstTestsRec. */
     uint32_t            cTestsRec;
@@ -258 +262 @@
     if (RT_SUCCESS(rc))
     {
-        LogRel(("Audio: Validation Kit: Registered guest recording test (%RU32ms, %RU64 bytes)\n",
-                pTestData->t.TestTone.Parms.msDuration, pTestData->t.TestTone.u.Rec.cbToWrite));
+        LogRel(("Audio: Validation Kit: Registered guest recording test #%RU32 (%RU32ms, %RU64 bytes)\n",
+                pThis->cTestsTotal, pTestData->t.TestTone.Parms.msDuration, pTestData->t.TestTone.u.Rec.cbToWrite));
 
         RTListAppend(&pThis->lstTestsRec, &pTestData->Node);
+
+        pTestData->idxTest = pThis->cTestsTotal++;
 
         pThis->cTestsRec++;
@@ -291 +297 @@
     if (RT_SUCCESS(rc))
     {
-        LogRel(("Audio: Validation Kit: Registered guest playback test (%RU32ms, %RU64 bytes)\n",
-                pTestData->t.TestTone.Parms.msDuration, pTestData->t.TestTone.u.Play.cbToRead));
+        LogRel(("Audio: Validation Kit: Registered guest playback test #%RU32 (%RU32ms, %RU64 bytes)\n",
+                pThis->cTestsTotal, pTestData->t.TestTone.Parms.msDuration, pTestData->t.TestTone.u.Play.cbToRead));
 
         RTListAppend(&pThis->lstTestsPlay, &pTestData->Node);
+
+        pTestData->idxTest = pThis->cTestsTotal++;
 
         pThis->cTestsPlay++;
@@ -512 +520 @@
                                     &Parms, &pTst->pEntry);
         if (RT_SUCCESS(rc))
-            rc = AudioTestSetObjCreateAndRegister(&pThis->Set, "guest-output.pcm", &pTst->pObj);
+            rc = AudioTestSetObjCreateAndRegister(&pThis->Set, "host-tone-rec.pcm", &pTst->pObj);
 
         if (RT_SUCCESS(rc))
@@ -533 +541 @@
         {
             pTst->t.TestTone.u.Play.cbRead += cbToRead;
-
             Assert(pTst->t.TestTone.u.Play.cbRead <= pTst->t.TestTone.u.Play.cbToRead);
 
@@ -613 +620 @@
                                     &Parms, &pTst->pEntry);
         if (RT_SUCCESS(rc))
-            rc = AudioTestSetObjCreateAndRegister(&pThis->Set, "host-input.pcm", &pTst->pObj);
+            rc = AudioTestSetObjCreateAndRegister(&pThis->Set, "host-tone-play.pcm", &pTst->pObj);
 
         if (RT_SUCCESS(rc))
@@ -794 +801 @@
 
         if (pThis->cTestsRec)
-            LogRel(("Audio: Validation Kit: Warning: %RU32 guest recording tests still outstanding\n", pThis->cTestsRec));
-        if (pThis->cTestsPlay)
-            LogRel(("Audio: Validation Kit: Warning: %RU32 guest playback tests still outstanding\n", pThis->cTestsPlay));
+            LogRel(("Audio: Validation Kit: Warning: %RU32 guest recording tests still outstanding:\n", pThis->cTestsRec));
 
         PVALKITTESTDATA pTst, pTstNext;
         RTListForEachSafe(&pThis->lstTestsRec, pTst, pTstNext, VALKITTESTDATA, Node)
+        {
+            size_t const cbOutstanding = pTst->t.TestTone.u.Rec.cbToWrite - pTst->t.TestTone.u.Rec.cbWritten;
+            if (cbOutstanding)
+                LogRel(("Audio: Validation Kit: \tRecording test #%RU32 has %RU64 bytes outstanding\n", pTst->idxTest, cbOutstanding));
             drvHostValKiUnregisterRecTest(pThis, pTst);
+        }
+
+        if (pThis->cTestsPlay)
+            LogRel(("Audio: Validation Kit: Warning: %RU32 guest playback tests still outstanding:\n", pThis->cTestsPlay));
 
         RTListForEachSafe(&pThis->lstTestsPlay, pTst, pTstNext, VALKITTESTDATA, Node)
+        {
+            size_t const cbOutstanding = pTst->t.TestTone.u.Play.cbToRead - pTst->t.TestTone.u.Play.cbRead;
+            if (cbOutstanding)
+                LogRel(("Audio: Validation Kit: \tPlayback test #%RU32 has %RU64 bytes outstanding\n", pTst->idxTest, cbOutstanding));
             drvHostValKiUnregisterPlayTest(pThis, pTst);
+        }
 
         Assert(pThis->cTestsRec == 0);

trunk/src/VBox/ValidationKit/utils/audio/vkatCommon.cpp

@@ -264 +264 @@
     /** @todo Use .WAV here? */
     PAUDIOTESTOBJ pObj;
-    int rc = AudioTestSetObjCreateAndRegister(&pTstEnv->Set, "tone-play.pcm", &pObj);
+    int rc = AudioTestSetObjCreateAndRegister(&pTstEnv->Set, "guest-tone-play.pcm", &pObj);
     AssertRCReturn(rc, rc);
 
@@ -341 +341 @@
     /** @todo Use .WAV here? */
     PAUDIOTESTOBJ pObj;
-    int rc = AudioTestSetObjCreateAndRegister(&pTstEnv->Set, "tone-rec.pcm", &pObj);
+    int rc = AudioTestSetObjCreateAndRegister(&pTstEnv->Set, "guest-tone-rec.pcm", &pObj);
     AssertRCReturn(rc, rc);
 
@@ -396 +396 @@
 *********************************************************************************************************************************/
 
-/** @copydoc ATSCALLBACKS::pfnTestSetBegin */
-static DECLCALLBACK(int) audioTestSvcTestSetBeginCallback(void const *pvUser, const char *pszTag)
+/** @copydoc ATSCALLBACKS::pfnTestSetBegin
+ *
+ *  @note Runs as part of the guest ATS.
+ */
+static DECLCALLBACK(int) audioTestGstAtsTestSetBeginCallback(void const *pvUser, const char *pszTag)
 {
     PATSCALLBACKCTX pCtx    = (PATSCALLBACKCTX)pvUser;
     PAUDIOTESTENV   pTstEnv = pCtx->pTstEnv;
 
-    RTTestPrintf(g_hTest, RTTESTLVL_DEBUG, "Beginning test set '%s'\n", pszTag);
+    RTTestPrintf(g_hTest, RTTESTLVL_DEBUG, "Beginning test set '%s' in '%s'\n", pszTag, pTstEnv->szPathTemp);
 
     return AudioTestSetCreate(&pTstEnv->Set, pTstEnv->szPathTemp, pszTag);
 }
 
-/** @copydoc ATSCALLBACKS::pfnTestSetEnd */
-static DECLCALLBACK(int) audioTestSvcTestSetEndCallback(void const *pvUser, const char *pszTag)
+/** @copydoc ATSCALLBACKS::pfnTestSetEnd
+ *
+ *  @note Runs as part of the guest ATS.
+ */
+static DECLCALLBACK(int) audioTestGstAtsTestSetEndCallback(void const *pvUser, const char *pszTag)
 {
     PATSCALLBACKCTX pCtx    = (PATSCALLBACKCTX)pvUser;
@@ -418 +424 @@
 }
 
-/** @copydoc ATSCALLBACKS::pfnTonePlay */
-static DECLCALLBACK(int) audioTestSvcTonePlayCallback(void const *pvUser, PAUDIOTESTTONEPARMS pToneParms)
+/** @copydoc ATSCALLBACKS::pfnTonePlay
+ *
+ *  @note Runs as part of the guest ATS.
+ */
+static DECLCALLBACK(int) audioTestGstAtsTonePlayCallback(void const *pvUser, PAUDIOTESTTONEPARMS pToneParms)
 {
     PATSCALLBACKCTX pCtx    = (PATSCALLBACKCTX)pvUser;
@@ -462 +471 @@
 
 /** @copydoc ATSCALLBACKS::pfnToneRecord */
-static DECLCALLBACK(int) audioTestSvcToneRecordCallback(void const *pvUser, PAUDIOTESTTONEPARMS pToneParms)
+static DECLCALLBACK(int) audioTestGstAtsToneRecordCallback(void const *pvUser, PAUDIOTESTTONEPARMS pToneParms)
 {
     PATSCALLBACKCTX pCtx    = (PATSCALLBACKCTX)pvUser;
@@ -480 +489 @@
 
         PAUDIOTESTENTRY pTst;
-        rc = AudioTestSetTestBegin(&pTstEnv->Set, "Recording test tone", &TstParms, &pTst);
+        rc = AudioTestSetTestBegin(&pTstEnv->Set, "Recording test tone from host", &TstParms, &pTst);
         if (RT_SUCCESS(rc))
         {
@@ -506 +515 @@
 *   Implementation of audio test environment handling                                                                            *
 *********************************************************************************************************************************/
+
+int audioTestEnvConnectToHostAts(PAUDIOTESTENV pTstEnv,
+                                 const char *pszHostTcpAddr, uint32_t uHostTcpPort)
+{
+    RTTestPrintf(g_hTest, RTTESTLVL_ALWAYS, "Connecting to host ATS at %s:%RU32 ...\n",
+                 (pszHostTcpAddr && *pszHostTcpAddr) ? pszHostTcpAddr : ATS_TCP_HOST_DEFAULT_ADDR_STR,
+                 uHostTcpPort ? uHostTcpPort : ATS_TCP_HOST_DEFAULT_PORT);
+
+    int rc = AudioTestSvcClientConnect(&pTstEnv->u.Host.AtsClValKit, pszHostTcpAddr, uHostTcpPort);
+    if (RT_FAILURE(rc))
+    {
+        RTTestFailed(g_hTest, "Connecting to host ATS failed with %Rrc\n", rc);
+        return rc;
+    }
+
+    RTTestPrintf(g_hTest, RTTESTLVL_ALWAYS, "Connected to host ATS\n");
+    return rc;
+}
+
+int audioTestEnvConnectToGuestAts(PAUDIOTESTENV pTstEnv,
+                                  const char *pszGuestTcpAddr, uint32_t uGuestTcpPort)
+{
+    RTTestPrintf(g_hTest, RTTESTLVL_DEBUG, "Connecting to guest ATS at %s:%RU32 ...\n",
+                 (pszGuestTcpAddr && *pszGuestTcpAddr) ? pszGuestTcpAddr : "127.0.0.1",
+                 uGuestTcpPort ? uGuestTcpPort : ATS_TCP_GUEST_DEFAULT_PORT);
+
+    int rc = AudioTestSvcClientConnect(&pTstEnv->u.Host.AtsClGuest, pszGuestTcpAddr, uGuestTcpPort);
+    if (RT_FAILURE(rc))
+    {
+        RTTestFailed(g_hTest, "Connecting to guest ATS failed with %Rrc\n", rc);
+        return rc;
+    }
+
+    RTTestPrintf(g_hTest, RTTESTLVL_ALWAYS, "Connected to guest ATS\n");
+    return rc;
+}
 
 /**
@@ -550 +595 @@
     }
 
-    if (pDrvReg == NULL) /* Go with the platform's default backend if nothing else is set. */
-        pDrvReg = g_aBackends[0].pDrvReg;
+    if (pDrvReg == NULL)
+    {
+        if (pTstEnv->fSelftest)
+            pDrvReg = &g_DrvHostValidationKitAudio;
+        else /* Go with the platform's default backend if nothing else is set. */
+            pDrvReg = g_aBackends[0].pDrvReg;
+    }
 
     if (!uHostTcpPort)
@@ -571 +621 @@
 
     /* Only the guest mode needs initializing the driver stack. */
-    const bool fUseDriverStack =    pTstEnv->enmMode == AUDIOTESTMODE_GUEST
-                                 /* The self test mode drives the ValKit audio driver locally,
-                                  * so also use the driver stack here. */
-                                 || (   pTstEnv->enmMode == AUDIOTESTMODE_HOST
-                                     && pTstEnv->fSelftest);
+    const bool fUseDriverStack = pTstEnv->enmMode == AUDIOTESTMODE_GUEST;
     if (fUseDriverStack)
     {
@@ -612 +658 @@
 
         ATSCALLBACKS Callbacks;
-        Callbacks.pfnTestSetBegin = audioTestSvcTestSetBeginCallback;
-        Callbacks.pfnTestSetEnd   = audioTestSvcTestSetEndCallback;
-        Callbacks.pfnTonePlay     = audioTestSvcTonePlayCallback;
-        Callbacks.pfnToneRecord   = audioTestSvcToneRecordCallback;
+        Callbacks.pfnTestSetBegin = audioTestGstAtsTestSetBeginCallback;
+        Callbacks.pfnTestSetEnd   = audioTestGstAtsTestSetEndCallback;
+        Callbacks.pfnTonePlay     = audioTestGstAtsTonePlayCallback;
+        Callbacks.pfnToneRecord   = audioTestGstAtsToneRecordCallback;
         Callbacks.pvUser          = &Ctx;
 
@@ -632 +678 @@
 
         if (RT_FAILURE(rc))
-        {
             RTTestFailed(g_hTest, "Starting ATS failed with %Rrc\n", rc);
-            return rc;
-        }
     }
     else /* Host mode */
     {
-        RTTestPrintf(g_hTest, RTTESTLVL_ALWAYS, "Connecting to host ATS at %s:%RU32 ...\n",
-                     (pszHostTcpAddr && *pszHostTcpAddr) ? pszHostTcpAddr : ATS_TCP_HOST_DEFAULT_ADDR_STR,
-                     uHostTcpPort ? uHostTcpPort : ATS_TCP_HOST_DEFAULT_PORT);
-
-        rc = AudioTestSvcClientConnect(&pTstEnv->u.Host.AtsClValKit, pszHostTcpAddr, uHostTcpPort);
-        if (RT_FAILURE(rc))
-        {
-            RTTestFailed(g_hTest, "Connecting to host ATS failed with %Rrc\n", rc);
-            return rc;
-        }
-
-        RTTestPrintf(g_hTest, RTTESTLVL_ALWAYS, "Connected to host ATS\n");
-
-        RTTestPrintf(g_hTest, RTTESTLVL_DEBUG, "Connecting to guest ATS at %s:%RU32 ...\n",
-                     (pszGuestTcpAddr && *pszGuestTcpAddr) ? pszGuestTcpAddr : "127.0.0.1",
-                     uGuestTcpPort ? uGuestTcpPort : ATS_TCP_GUEST_DEFAULT_PORT);
-
-        rc = AudioTestSvcClientConnect(&pTstEnv->u.Host.AtsClGuest, pszGuestTcpAddr, uGuestTcpPort);
-        if (RT_FAILURE(rc))
-        {
-            RTTestFailed(g_hTest, "Connecting to guest ATS failed with %Rrc\n", rc);
-            return rc;
-        }
-
-        RTTestPrintf(g_hTest, RTTESTLVL_ALWAYS, "Connected to guest ATS\n");
+        rc = audioTestEnvConnectToHostAts(pTstEnv, pszHostTcpAddr, uHostTcpPort);
+        if (RT_SUCCESS(rc))
+            rc = audioTestEnvConnectToGuestAts(pTstEnv, pszGuestTcpAddr, uGuestTcpPort);
     }
 

trunk/src/VBox/ValidationKit/utils/audio/vkatInternal.h

@@ -410 +410 @@
 /** @}  */
 
+/** @name ATS routines
+ * @{ */
+int         audioTestEnvConnectToHostAts(PAUDIOTESTENV pTstEnv,
+                                         const char *pszHostTcpAddr, uint32_t uHostTcpPort);
+/** @}  */
+
 /** @name Test environment handling
  * @{ */