Changeset 8961 in vbox for trunk/src/VBox/VMM

Timestamp:

May 20, 2008 2:51:33 PM (17 years ago)

Author:

vboxsync

Message:

Fixed amd64 debug builds. Added some TODOs.

File:

• trunk/src/VBox/VMM/VMMR0/VMMR0.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

@@ -1088 +1088 @@
 
 /**
- * Override this so we can push
+ * Override this so we can push it up to ring-3.
  *
  * @param   pszExpr     Expression. Can be NULL.
@@ -1094 +1094 @@
  * @param   pszFile     Location file name.
  * @param   pszFunction Location function name.
- * @remark  This API exists in HC Ring-3 and GC.
  */
 DECLEXPORT(void) RTCALL AssertMsg1(const char *pszExpr, unsigned uLine, const char *pszFile, const char *pszFunction)
@@ -1112 +1111 @@
 
 /**
- * Callback for RTLogFormatV which writes to the com port.
+ * Callback for RTLogFormatV which writes to the ring-3 log port.
  * See PFNLOGOUTPUT() for details.
  */
@@ -1119 +1118 @@
     for (size_t i = 0; i < cbChars; i++)
     {
-        LogAlways(("%c", pachChars[i])); /** @todo this isn't any release logging in ring-0 from what I can tell... */
 #ifndef DEBUG_sandervl
         SUPR0Printf("%c", pachChars[i]);
 #endif
+        LogAlways(("%c", pachChars[i]));
     }
 
@@ -1131 +1130 @@
 DECLEXPORT(void) RTCALL AssertMsg2(const char *pszFormat, ...)
 {
-    PRTLOGGER pLog = RTLogDefaultInstance();
+    PRTLOGGER pLog = RTLogDefaultInstance(); /** @todo we want this for release as well! */
     if (pLog)
     {