Changeset 8967 in vbox

Timestamp:

May 20, 2008 4:51:08 PM (17 years ago)

Author:

vboxsync

Message:

Linux vboxadd kernel module: Fixed guest kernel crash during shutdown. Sometimes we received interrupts during module unloading.

File:

• trunk/src/VBox/Additions/linux/module/vboxmod.c (modified) (4 diffs)

trunk/src/VBox/Additions/linux/module/vboxmod.c

@@ -24 +24 @@
 
 /* #define IRQ_DEBUG */
-// #define IOCTL_DEBUG
+/* #define IOCTL_DEBUG */
 #ifdef IOCTL_DEBUG
 # define IOCTL_ENTRY(name, arg) \
@@ -676 +676 @@
     else
     {
+        /* we might be attached to a shared interrupt together with another device. */
         Log(("vboxadd IRQ_DEBUG: stale IRQ mem=%p events=%d devevents=%#x\n",
              vboxDev->pVMMDevMemory,
@@ -816 +817 @@
     if (vboxDev)
     {
+        /* at first detach from IRQ! */
+        if (vboxDev->irq)
+            free_irq(vboxDev->irq, vboxDev);
         if (vboxDev->hypervisorStart)
-        {
             vboxadd_free_hypervisor();
-        }
         if (vboxDev->irqAckRequest)
         {
@@ -829 +831 @@
         if (vboxDev->vmmdevmem)
             release_mem_region(vboxDev->vmmdevmem, vboxDev->vmmdevmem_size);
-        if (vboxDev->irq)
-            free_irq(vboxDev->irq, vboxDev);
         kfree(vboxDev);
         vboxDev = NULL;