Changeset 89681 in vbox for trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

Timestamp:

Jun 14, 2021 1:29:37 PM (3 years ago)

Author:

vboxsync

Message:

DevIchAc97: Try deal with zero sized buffer descriptors (untested). Moved CIV advancing to ichac97R3StreamFetchBDLE, renaming it to ichac97R3StreamFetchNextBdle. Added four ASSERT_GUEST check on reserved BDLE bits and odd lengths. [build fix] bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -856 +856 @@
         pStream->Regs.picb       = pStream->Regs.bd.ctl_len & AC97_BD_LEN_MASK;
 
-        LogFlowFunc(("BDLE%02u: %#RX32 L %#x / LB %#x, ctl=%#06x\n",
+        LogFlowFunc(("BDLE%02u: %#RX32 L %#x / LB %#x, ctl=%#06x%s%s\n",
                      pStream->Regs.civ, pStream->Regs.bd.addr, pStream->Regs.bd.ctl_len & AC97_BD_LEN_MASK,
                      (pStream->Regs.bd.ctl_len & AC97_BD_LEN_MASK) * PDMAudioPropsSampleSize(&pStreamCC->State.Cfg.Props),
@@ -881 +881 @@
 
         /* If the buffer has IOC set, make sure it's triggered by the caller. */
-        if (   (pStream->Regs.bd.ctl_len & AC97_BD_IOC)
-            && (pStream->Regs.bd.ctl_len & AC97_BD_IOC))
+        if (pStream->Regs.bd.ctl_len & AC97_BD_IOC)
             fSrBcis |= AC97_SR_BCIS;
     }