Changeset 89719 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jun 15, 2021 6:51:56 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145170

Message:

VBoxManage: change the error printing to use the standard code for this purpose, and add a todo for handling the warnings this way, too.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageAppliance.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageAppliance.cpp

@@ -444 +444 @@
             RTStrmPrintf(g_pStdErr, "Interpreting %ls...\n", path.raw());
             rc = pAppliance->Interpret();
-            com::ErrorInfo info0(pAppliance, COM_IIDOF(IAppliance));
-
+            com::ErrorInfoKeeper eik;
+
+            /** @todo r=klaus Eliminate this special way of signalling
+             * warnings which should be part of the ErrorInfo. */
             com::SafeArray<BSTR> aWarnings;
             if (SUCCEEDED(pAppliance->GetWarnings(ComSafeArrayAsOutParam(aWarnings))))
@@ -457 +459 @@
             }
 
+            eik.restore();
             if (FAILED(rc))     // during interpret, after printing warnings
             {
-                com::GluePrintErrorInfo(info0);
-                com::GluePrintErrorContext("Interpret", __FILE__, __LINE__);
+                com::GlueHandleComError(pAppliance, "Interpret()", rc, __FILE__, __LINE__);
                 break;
             }