Changeset 89735 in vbox

Timestamp:

Jun 16, 2021 8:13:58 AM (3 years ago)

Author:

vboxsync

Message:

DevRTC: Added more statistics to the RTC device, tracking interrupt behavior. Also a few more symbolic constants instead of hardcoded numbers.

File:

• trunk/src/VBox/Devices/PC/DevRTC.cpp (modified) (9 diffs)

trunk/src/VBox/Devices/PC/DevRTC.cpp

@@ -94 +94 @@
 #define REG_B_UIE 0x10
 
+#define REG_C_IRQF  0x80
+#define REG_C_PF    0x40
+#define REG_C_AF    0x20
+#define REG_C_UF    0x10
+
 #define CMOS_BANK_LOWER_LIMIT   0x0E
 #define CMOS_BANK_UPPER_LIMIT   0x7F
@@ -171 +176 @@
     /** Number of times the timer callback handler ran. */
     STAMCOUNTER             StatRTCTimerCB;
+    /** Number of times the PIE bit was changed. */
+    STAMCOUNTER             StatRTCPieFlip;
+    /** Number of times an interrupt was cleared. */
+    STAMCOUNTER             StatRTCIrqClear;
+    /** How long the periodic interrupt remains active. */
+    STAMPROFILEADV          StatPIrqPending;
 } RTCSTATE;
 /** Pointer to the RTC device state. */
@@ -381 +392 @@
             case RTC_REG_C:
                 *pu32 = pThis->cmos_data[pThis->cmos_index[0]];
+                if (*pu32)  /* If any bits were set, reading will clear them. */
+                {
+                    STAM_REL_COUNTER_INC(&pThis->StatRTCIrqClear);
+                    if (pThis->cmos_data[RTC_REG_C] & REG_C_PF)
+                        STAM_REL_PROFILE_ADV_STOP(&pThis->StatPIrqPending, dummy);
+                }
                 rtc_raise_irq(pDevIns, pThis, 0);
                 pThis->cmos_data[RTC_REG_C] = 0x00;
@@ -481 +498 @@
                             rtc_set_time(pThis);
                     }
+
+                    if (((uint8_t)u32 & REG_B_PIE) != (pThis->cmos_data[RTC_REG_B] & REG_B_PIE))
+                        STAM_REL_COUNTER_INC(&pThis->StatRTCPieFlip);
+
                     pThis->cmos_data[RTC_REG_B] = u32;
                 }
@@ -579 +600 @@
                     pThis->cmos_data[RTC_REG_A], pThis->cmos_data[RTC_REG_B],
                     pThis->cmos_data[RTC_REG_C], pThis->cmos_data[RTC_REG_D]);
+
+    if (pThis->cmos_data[RTC_REG_B] & REG_B_PIE)
+    {
+        if (pThis->CurHintPeriod)
+            pHlp->pfnPrintf(pHlp, "Periodic Interrupt Enabled: %d Hz\n", _32K / pThis->CurHintPeriod);
+    }
 }
 
@@ -599 +626 @@
     rtc_timer_update(pDevIns, pThis, pThis->next_periodic_time);
     STAM_REL_COUNTER_INC(&pThis->StatRTCTimerCB);
-    pThis->cmos_data[RTC_REG_C] |= 0xc0;
+
+    if (!(pThis->cmos_data[RTC_REG_C] & REG_C_PF))
+        STAM_REL_PROFILE_ADV_START(&pThis->StatPIrqPending, dummy);
+
+    pThis->cmos_data[RTC_REG_C] |= REG_C_IRQF | REG_C_PF;
 
     rtc_raise_irq(pDevIns, pThis, 1);
@@ -756 +787 @@
             )
         {
-            pThis->cmos_data[RTC_REG_C] |= 0xa0;
+            pThis->cmos_data[RTC_REG_C] |= REG_C_IRQF | REG_C_AF;
             rtc_raise_irq(pDevIns, pThis, 1);
         }
@@ -764 +795 @@
     if (pThis->cmos_data[RTC_REG_B] & REG_B_UIE)
     {
-        pThis->cmos_data[RTC_REG_C] |= 0x90;
+        pThis->cmos_data[RTC_REG_C] |= REG_C_IRQF | REG_C_UF;
         rtc_raise_irq(pDevIns, pThis, 1);
     }
@@ -1222 +1253 @@
      * Register statistics.
      */
-    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatRTCIrq,      STAMTYPE_COUNTER, "Irq",      STAMUNIT_OCCURENCES,  "The number of times a RTC interrupt was triggered.");
-    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatRTCTimerCB,  STAMTYPE_COUNTER, "TimerCB",  STAMUNIT_OCCURENCES,  "The number of times the RTC timer callback ran.");
+    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatRTCIrq,      STAMTYPE_COUNTER, "Irq",      STAMUNIT_OCCURENCES,      "The number of times a RTC interrupt was triggered.");
+    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatRTCTimerCB,  STAMTYPE_COUNTER, "TimerCB",  STAMUNIT_OCCURENCES,      "The number of times the RTC timer callback ran.");
+    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatRTCPieFlip,  STAMTYPE_COUNTER, "PieFlip",  STAMUNIT_OCCURENCES,      "The number of times Periodic Interrupt Enable changed.");
+    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatRTCIrqClear, STAMTYPE_COUNTER, "IrqClear", STAMUNIT_OCCURENCES,      "The number of times an active interrupt was cleared.");
+    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatPIrqPending, STAMTYPE_PROFILE, "PiActive", STAMUNIT_TICKS_PER_CALL,  "How long periodic interrupt stays active (pending).");
 
     return VINF_SUCCESS;