Changeset 89758 in vbox

Timestamp:

Jun 16, 2021 11:36:09 PM (3 years ago)

Author:

vboxsync

Message:

DevIchAc97: Profile ichac97R3StreamReSetUp as it is doing the heavy lifting wrt stream setup. bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -404 +404 @@
     STAMPROFILE             StatReset;
     STAMPROFILE             StatStop;
+    STAMPROFILE             StatReSetUpChanged;
+    STAMPROFILE             StatReSetUpSame;
     STAMCOUNTER             StatWriteLviRecover;
     STAMCOUNTER             StatWriteCr;
@@ -1961 +1963 @@
  *
  * @returns VBox status code.
+ * @retval  VINF_NO_CHANGE if the streams weren't re-created.
+ *
  * @param   pDevIns     The device instance.
  * @param   pThis       The shared AC'97 device state (shared).
@@ -2199 +2203 @@
     }
     else
+    {
         LogFlowFunc(("[SD%RU8] Skipping set-up (unchanged: %s)\n",
                      pStreamCC->u8SD, PDMAudioStrmCfgToString(&Cfg, szTmp, sizeof(szTmp))));
+        rc = VINF_NO_CHANGE;
+    }
     return rc;
 }
@@ -2236 +2243 @@
                                   PAC97STREAM pStream, PAC97STREAMR3 pStreamCC, bool fForce)
 {
+    STAM_REL_PROFILE_START_NS(&pStreamCC->State.StatReSetUpChanged, r);
     LogFlowFunc(("[SD%RU8]\n", pStream->u8SD));
     Assert(pStream->u8SD == pStreamCC->u8SD);
@@ -2242 +2250 @@
 
     ichac97R3StreamTearDown(pStream);
-    return ichac97R3StreamSetUp(pDevIns, pThis, pThisCC, pStream, pStreamCC, fForce);
+    int rc = ichac97R3StreamSetUp(pDevIns, pThis, pThisCC, pStream, pStreamCC, fForce);
+    if (rc == VINF_NO_CHANGE)
+        STAM_REL_PROFILE_STOP_NS(&pStreamCC->State.StatReSetUpSame, r);
+    else
+        STAM_REL_PROFILE_STOP_NS(&pStreamCC->State.StatReSetUpChanged, r);
+    return rc;
 }
 
@@ -4511 +4524 @@
         PDMDevHlpSTAMRegisterF(pDevIns, &pThis->aStreams[idxStream].Regs.sr, STAMTYPE_X16, STAMVISIBILITY_ALWAYS, STAMUNIT_NONE,
                                "Status register (SR).",                         "Stream%u/reg-SR", idxStream);
-        PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.Cfg.Props.uHz, STAMTYPE_U32, STAMVISIBILITY_USED, STAMUNIT_BYTES,
+        PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.Cfg.Props.uHz, STAMTYPE_U32, STAMVISIBILITY_USED, STAMUNIT_HZ,
                                "The stream frequency.",                         "Stream%u/Hz", idxStream);
         PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.Cfg.Props.cbFrame, STAMTYPE_U8, STAMVISIBILITY_USED, STAMUNIT_BYTES,
@@ -4542 +4555 @@
         PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.StatReset, STAMTYPE_PROFILE, STAMVISIBILITY_USED, STAMUNIT_NS_PER_CALL,
                                "Resetting the stream.",  "Stream%u/Reset", idxStream);
+        PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.StatReSetUpChanged, STAMTYPE_PROFILE, STAMVISIBILITY_USED, STAMUNIT_NS_PER_CALL,
+                               "ichac97R3StreamReSetUp when recreating the streams.", "Stream%u/ReSetUp-Change", idxStream);
+        PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.StatReSetUpSame, STAMTYPE_PROFILE, STAMVISIBILITY_USED, STAMUNIT_NS_PER_CALL,
+                               "ichac97R3StreamReSetUp when no change.",        "Stream%u/ReSetUp-NoChange", idxStream);
         PDMDevHlpSTAMRegisterF(pDevIns, &pThisCC->aStreams[idxStream].State.StatWriteCr, STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,
                                "CR register writes.",                           "Stream%u/WriteCr", idxStream);