Changeset 8981 in vbox

Timestamp:

May 20, 2008 7:59:52 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

31055

Message:

FE/Qt4: Don't show pseudo errors when accessing uavailable objects like VRDP Server in OSE (#2830).

Location:

trunk/src/VBox/Frontends

Files:

• VirtualBox/src/VBoxProblemReporter.cpp (modified) (2 diffs)
• VirtualBox4/src/VBoxProblemReporter.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxProblemReporter.cpp

@@ -667 +667 @@
 
 /**
- *  @param  strict  if |true| then show the message even if there is no basic
- *                  error info available
+ * @param  strict  If |false|, this method will silently return if the COM
+ *                 result code is E_NOTIMPL.
  */
 void VBoxProblemReporter::cannotLoadMachineSettings (const CMachine &machine,
@@ -674 +674 @@
                                                      QWidget *parent /* = 0 */)
 {
+    /* If COM result code is E_NOTIMPL, it means the requested object or
+     * function is intentionally missing (as in the OSE version). Don't show
+     * the error message in this case. */
     COMResult res (machine);
-    if (!strict && !res.errorInfo().isBasicAvailable())
+    if (!strict && res.rc() == E_NOTIMPL)
         return;
 

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxProblemReporter.cpp

@@ -675 +675 @@
 
 /**
- *  @param  strict  if |true| then show the message even if there is no basic
- *                  error info available
+ * @param  strict  If |false|, this method will silently return if the COM
+ *                 result code is E_NOTIMPL.
  */
 void VBoxProblemReporter::cannotLoadMachineSettings (const CMachine &machine,
@@ -682 +682 @@
                                                      QWidget *parent /* = 0 */)
 {
+    /* If COM result code is E_NOTIMPL, it means the requested object or
+     * function is intentionally missing (as in the OSE version). Don't show
+     * the error message in this case. */
     COMResult res (machine);
-    if (!strict && !res.errorInfo().isBasicAvailable())
+    if (!strict && res.rc() == E_NOTIMPL)
         return;