Changeset 89852 in vbox for trunk/src/VBox/Main/src-client

Timestamp:

Jun 23, 2021 1:14:23 PM (4 years ago)

Author:

vboxsync

Message:

Audio/Main: Addendum for r144627 -- also run the ValKit backend in parallel when debug mode is enabled -- nice for immediately spotting audible errors. bugref:10008

File:

• trunk/src/VBox/Main/src-client/ConsoleImpl2.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/ConsoleImpl2.cpp

@@ -3023 +3023 @@
             if (strTmp.isEmpty())
                 GetExtraDataBoth(virtualBox, pMachine, "VBoxInternal2/Audio/ValKit/Enabled", &strTmp);
+            /* Whether the Validation Kit audio backend runs as the primary backend.
+             * Can also be used with VBox release builds. */
             const bool fValKitEnabled = strTmp.equalsIgnoreCase("true") || strTmp.equalsIgnoreCase("1");
 #endif
@@ -3261 +3263 @@
                  *
                  * The ValidationKit audio driver has precedence over the Debug audio driver.
+                 *
+                 * This also can (and will) be used in VBox release builds.
                  */
                 if (fValKitEnabled)
@@ -3266 +3270 @@
                     LogRel(("Audio: Warning: ValidationKit running and Debug mode enabled -- disabling Debug driver\n"));
                 }
-                else
-                {
+                else /* Debug mode active -- run both (nice for catching errors / doing development). */
+                {
+                    /*
+                     * The ValidationKit backend.
+                     */
+                    InsertConfigNodeF(pInst, &pLunL0, "LUN#%u", idxAudioLun);
+                    i_configAudioDriver(virtualBox, pMachine, pLunL0, "ValidationKitAudio",
+                                        !!fAudioEnabledIn, !!fAudioEnabledOut);
+                    idxAudioLun++;
 # endif /* VBOX_WITH_AUDIO_VALIDATIONKIT */
+                    /*
+                     * The Debug audio backend.
+                     */
                     InsertConfigNodeF(pInst, &pLunL0, "LUN#%u", idxAudioLun);
-                    i_configAudioDriver(virtualBox, pMachine, pLunL0, "DebugAudio", !!fAudioEnabledIn, !!fAudioEnabledOut);
+                    i_configAudioDriver(virtualBox, pMachine, pLunL0, "DebugAudio",
+                                        !!fAudioEnabledIn, !!fAudioEnabledOut);
                     idxAudioLun++;
 # ifdef VBOX_WITH_AUDIO_VALIDATIONKIT