Changeset 89937 in vbox for trunk/src/VBox/Devices/Input

Timestamp:

Jun 29, 2021 6:53:59 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145395

Message:

Warnings.

File:

• trunk/src/VBox/Devices/Input/UsbKbd.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Input/UsbKbd.cpp

@@ -462 +462 @@
     else if (u8HidPage == USB_HID_CC_PAGE)
     {
-        for (int i = 0; i < RT_ELEMENTS(aHidCCKeys); ++i)
+        for (unsigned i = 0; i < RT_ELEMENTS(aHidCCKeys); ++i)
             if (aHidCCKeys[i] == u16HidUsage)
             {
@@ -472 +472 @@
     else if (u8HidPage == USB_HID_DC_PAGE)
     {
-        for (int i = 0; i < RT_ELEMENTS(aHidDCKeys); ++i)
+        for (unsigned i = 0; i < RT_ELEMENTS(aHidDCKeys); ++i)
             if (aHidCCKeys[i] == u16HidUsage)
             {
@@ -499 +499 @@
  * @param   u32HidCode          32-bit USB HID code.
  */
-static uint32_t usbInternalCodeToHid(int iKeyCode)
+static uint32_t usbInternalCodeToHid(unsigned uKeyCode)
 {
     uint16_t    u16HidUsage;
     uint32_t    u32HidCode = 0;
 
-    if ((iKeyCode >= USBHID_PAGE_DC_START) && (iKeyCode <= USBHID_PAGE_DC_END))
-    {
-        u16HidUsage = aHidDCKeys[iKeyCode - USBHID_PAGE_DC_START];
+    if ((uKeyCode >= USBHID_PAGE_DC_START) && (uKeyCode <= USBHID_PAGE_DC_END))
+    {
+        u16HidUsage = aHidDCKeys[uKeyCode - USBHID_PAGE_DC_START];
         u32HidCode  = RT_MAKE_U32(u16HidUsage, USB_HID_DC_PAGE);
     }
-    else if ((iKeyCode >= USBHID_PAGE_CC_START) && (iKeyCode <= USBHID_PAGE_CC_END))
-    {
-        u16HidUsage = aHidCCKeys[iKeyCode - USBHID_PAGE_CC_START];
+    else if ((uKeyCode >= USBHID_PAGE_CC_START) && (uKeyCode <= USBHID_PAGE_CC_END))
+    {
+        u16HidUsage = aHidCCKeys[uKeyCode - USBHID_PAGE_CC_START];
         u32HidCode  = RT_MAKE_U32(u16HidUsage, USB_HID_CC_PAGE);
     }
     else    /* Must be the keyboard usage page. */
     {
-        if (iKeyCode <= VBOX_USB_MAX_USAGE_CODE)
-            u32HidCode = RT_MAKE_U32(iKeyCode, USB_HID_KB_PAGE);
+        if (uKeyCode <= VBOX_USB_MAX_USAGE_CODE)
+            u32HidCode = RT_MAKE_U32(uKeyCode, USB_HID_KB_PAGE);
         else
-            AssertMsgFailed(("iKeyCode out of range! (%d)\n", iKeyCode));
+            AssertMsgFailed(("uKeyCode out of range! (%u)\n", uKeyCode));
     }