Changeset 90040 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Jul 5, 2021 8:05:25 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145534

Message:

FE/Qt: bugref:9996: Cleaning on unattended page.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm

Files:

• UIWizardNewVM.cpp (modified) (6 diffs)
• UIWizardNewVM.h (modified) (5 diffs)
• UIWizardNewVMUnattendedPageBasic.cpp (modified) (6 diffs)
• UIWizardNewVMUnattendedPageBasic.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVM.cpp

@@ -62 +62 @@
     , m_iUSBCount(0)
     , m_fInstallGuestAdditions(false)
+    , m_fStartHeadless(false)
+    , m_fSkipUnattendedInstall(false)
 {
 #ifndef VBOX_WS_MAC
@@ -74 +76 @@
 
     connect(this, &UIWizardNewVM::rejected, this, &UIWizardNewVM::sltHandleWizardCancel);
-}
-
-void UIWizardNewVM::prepare()
-{
-    // enableHelpButton("gui-createvm");
-    // /* Create corresponding pages: */
-    // switch (mode())
-    // {
-    //     case WizardMode_Basic:
-    //     {
-    //         // setPage(Page1, new UIWizardNewVMPageNameOSType(m_strMachineGroup));
-    //         // setPage(Page2, new UIWizardNewVMPageUnattended);
-    //         // setPage(Page3, new UIWizardNewVMPageHardware);
-    //         // setPage(Page4, new UIWizardNewVMPageDisk);
-
-    //         // setStartId(Page1);
-    //         break;
-    //     }
-    //     case WizardMode_Expert:
-    //     {
-    //         setPage(PageExpert, new UIWizardNewVMPageExpert(m_strMachineGroup));
-    //         break;
-    //     }
-    //     default:
-    //     {
-    //         AssertMsgFailed(("Invalid mode: %d", mode()));
-    //         break;
-    //     }
-    // }
-    // /* Call to base-class: */
-    // UIWizard::prepare();
 }
 
@@ -525 +496 @@
 }
 
-// void UIWizardNewVM::sltHandleDetectedOSTypeChange()
-// {
-//     // UIWizardNewVMPageNameOSType *pPage = qobject_cast<UIWizardNewVMPageNameOSType*>(page(Page1));
-//     // if (!pPage)
-//     //     return;
-//     // pPage->setTypeByISODetectedOSType(getStringFieldValue("detectedOSTypeId"));
-// }
-
-void UIWizardNewVM::sltCustomButtonClicked(int iId)
-{
-    Q_UNUSED(iId);
-    // UIWizard::sltCustomButtonClicked(iId);
-    // setFieldsFromDefaultUnttendedInstallData();
-}
-
 void UIWizardNewVM::retranslateUi()
 {
-    /* Call to base-class: */
     UINativeWizard::retranslateUi();
-
     setWindowTitle(tr("Create Virtual Machine"));
     // setButtonText(QWizard::FinishButton, tr("Create"));
@@ -722 +676 @@
 {
     m_fInstallGuestAdditions = fInstallGA;
+}
+
+bool UIWizardNewVM::startHeadless() const
+{
+    return m_fStartHeadless;
+}
+
+void UIWizardNewVM::setStartHeadless(bool fStartHeadless)
+{
+    m_fStartHeadless = fStartHeadless;
+}
+
+bool UIWizardNewVM::skipUnattendedInstall() const
+{
+    return m_fSkipUnattendedInstall;
+}
+
+void UIWizardNewVM::setSkipUnattendedInstall(bool fSkipUnattendedInstall)
+{
+    m_fSkipUnattendedInstall = fSkipUnattendedInstall;
 }
 
@@ -799 +773 @@
     m_unattendedInstallData.m_strGuestAdditionsISOPath = m_strGuestAdditionsISOPath;
 
-    // m_unattendedInstallData.m_fUnattendedEnabled = getBoolFieldValue("isUnattendedEnabled");
-    // m_unattendedInstallData.m_fStartHeadless = getBoolFieldValue("startHeadless");
+    m_unattendedInstallData.m_fUnattendedEnabled = isUnattendedEnabled();
+    m_unattendedInstallData.m_fStartHeadless = m_fStartHeadless;
     m_unattendedInstallData.m_fInstallGuestAdditions = m_fInstallGuestAdditions;
     // m_unattendedInstallData.m_uMachineUid = createdMachineId();
@@ -809 +783 @@
 bool UIWizardNewVM::isUnattendedEnabled() const
 {
-    // QVariant fieldValue = field("isUnattendedEnabled");
-    // if (fieldValue.isNull() || !fieldValue.isValid() || !fieldValue.canConvert(QMetaType::Bool))
-    //     return false;
-    // return fieldValue.toBool();
+    if (!m_fSkipUnattendedInstall)
+        return false;
+    if (m_strISOFilePath.isEmpty() || m_strISOFilePath.isNull())
+        return false;
     return true;
 }

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVM.h

@@ -71 +71 @@
 public:
 
-
-    /** Constructor: */
     UIWizardNewVM(QWidget *pParent, const QString &strMachineGroup = QString(), WizardMode enmMode = WizardMode_Auto);
-
-    /** Prepare routine. */
-    void prepare();
-
     /** Returns the Id of newly created VM. */
     QUuid createdMachineId() const;
+    bool isUnattendedEnabled() const;
     void setDefaultUnattendedInstallData(const UIUnattendedInstallData &unattendedInstallData);
     const UIUnattendedInstallData &unattendedInstallData() const;
-    bool isUnattendedEnabled() const;
     bool isGuestOSTypeWindows() const;
     CMedium &virtualDisk();
@@ -111 +105 @@
     void setInstallGuestAdditions(bool fInstallGA);
 
+    bool startHeadless() const;
+    void setStartHeadless(bool fStartHeadless);
+
+    bool skipUnattendedInstall() const;
+    void setSkipUnattendedInstall(bool fSkipUnattendedInstall);
+
     const QString &ISOFilePath() const;
     void setISOFilePath(const QString &strISOFilePath);
@@ -132 +132 @@
 
     /** Populates pages. */
-    virtual void populatePages() /* final */;
+    virtual void populatePages() /* final override */;
 
     bool createVM();
@@ -149 +149 @@
 private:
 
-    /* Translation stuff: */
     void retranslateUi();
-
-
-    /* Helping stuff: */
     QString getNextControllerName(KStorageBus type);
     void setFieldsFromDefaultUnttendedInstallData();
@@ -193 +189 @@
     /** True if guest additions are to be installed during unattended install. */
     bool m_fInstallGuestAdditions;
+    bool m_fStartHeadless;
+    bool m_fSkipUnattendedInstall;
 
     QString m_strUserName;

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMUnattendedPageBasic.cpp

@@ -40 +40 @@
 #include "CUnattended.h"
 
-// QString UIWizardNewVMUnattendedPage::productKey() const
-// {
-//     if (!m_pProductKeyLineEdit || !m_pProductKeyLineEdit->hasAcceptableInput())
-//         return QString();
-//     return m_pProductKeyLineEdit->text();
-// }
-
-
 bool UIWizardNewVMUnattendedPage::checkGAISOFile(UIFilePathSelector *pGAISOFilePathSelector)
 {
@@ -61 +53 @@
     return true;
 }
-
-
-
-// bool UIWizardNewVMUnattendedPage::startHeadless() const
-// {
-//     if (!m_pStartHeadlessCheckBox)
-//         return false;
-//     return m_pStartHeadlessCheckBox->isChecked();
-// }
-
 
 UIWizardNewVMUnattendedPageBasic::UIWizardNewVMUnattendedPageBasic()
@@ -114 +96 @@
                 this, &UIWizardNewVMUnattendedPageBasic::sltUserNameChanged);
     }
-
     if (m_pGAISOFilePathSelector)
         connect(m_pGAISOFilePathSelector, &UIFilePathSelector::pathChanged,
@@ -127 +108 @@
         connect(m_pProductKeyLineEdit, &QLineEdit::textChanged,
                 this, &UIWizardNewVMUnattendedPageBasic::sltProductKeyChanged);
-
+    if (m_pStartHeadlessCheckBox)
+        connect(m_pStartHeadlessCheckBox, &QCheckBox::toggled,
+                this, &UIWizardNewVMUnattendedPageBasic::sltStartHeadlessChanged);
 }
 
@@ -149 +132 @@
         m_pGAInstallationISOContainer->setTitle(UIWizardNewVM::tr("Gu&est Additions"));
         m_pGAInstallationISOContainer->setToolTip(UIWizardNewVM::tr("<p>When checked the guest additions will be installed "
-                                                           "after the OS install.</p>"));
+                                                                    "after the OS install.</p>"));
     }
     if (m_pProductKeyLabel)
@@ -239 +222 @@
     if (m_pWizard)
         m_pWizard->setProductKey(strProductKey);
+}
+
+void UIWizardNewVMUnattendedPageBasic::sltStartHeadlessChanged(bool fStartHeadless)
+{
+    if (m_pWizard)
+        m_pWizard->setStartHeadless(fStartHeadless);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMUnattendedPageBasic.h

@@ -41 +41 @@
 namespace UIWizardNewVMUnattendedPage
 {
+    /** Returns false if ISO path selector is non empty but has invalid file path. */
     bool checkGAISOFile(UIFilePathSelector *pGAISOFilePathSelector);
-//     UIWizardNewVMUnattendedPage();
-
-//     /** @name Property getters/setters
-//       * @{ */
-//         QString userName() const;
-//         void setUserName(const QString &strName);
-//         QString password() const;
-//         void setPassword(const QString &strPassword);
-//         QString hostname() const;
-//         void setHostname(const QString &strHostName);
-//         QString guestAdditionsISOPath() const;
-//         void setGuestAdditionsISOPath(const QString &strISOPath);
-//         QString productKey() const;
-//     /** @} */
-
-
-//     /** Returns false if ISO path selector is non empty but has invalid file path. */
-//     bool checkGAISOFile() const;
-
-//     void retranslateWidgets();
-
-
-//     bool startHeadless() const;
-
-
 }
 
@@ -91 +67 @@
     void sltHostnameChanged(const QString &strHostname);
     void sltProductKeyChanged(const QString &strProductKey);
+    void sltStartHeadlessChanged(bool fStartHeadless);
 
 private: