Changeset 90078 in vbox for trunk/src

Timestamp:

Jul 7, 2021 4:31:06 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145575

Message:

NAT/Net: VBoxNetLwipNAT::processFrame - drop the assert part of
AssertReturn checks. These are not part of the intnet contract,
so convert them to plain ifs. bugref:9929.

File:

• trunk/src/VBox/NetworkServices/NAT/VBoxNetLwipNAT.cpp (modified) (1 diff)

trunk/src/VBox/NetworkServices/NAT/VBoxNetLwipNAT.cpp

@@ -1875 +1875 @@
 {
     AssertReturnVoid(pvFrame != NULL);
-    AssertReturnVoid(cbFrame != 0);
-    AssertReturnVoid(cbFrame <= 1522); /* include .1Q and FCS */
+
+    /* shouldn't happen, but if it does, don't even bother */
+    if (RT_UNLIKELY(cbFrame < sizeof(RTNETETHERHDR)))
+        return;
+
+    /* we expect normal ethernet frame including .1Q and FCS */
+    if (cbFrame > 1522)
+        return;
 
     AssertReturnVoid(pvUser != NULL);