Changeset 90156 in vbox for trunk/src

Timestamp:

Jul 12, 2021 8:36:16 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145659

Message:

Dev/VirtioNet: (bugref:8651) Fixed connectivity loss due to stuck TX thread on cable disconnection.

File:

• trunk/src/VBox/Devices/Network/DevVirtioNet.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Network/DevVirtioNet.cpp

@@ -1352 +1352 @@
 {
     /*
+     * Let's deal with the cases we are not going to transmit anything,
+     * to avoid setting 'uIsTransmitting' on and off.
+     */
+    if ((pThis->VPCI.uStatus & VPCI_STATUS_DRV_OK) == 0)
+    {
+        Log(("%s Ignoring transmit requests from non-existent driver (status=0x%x).\n", INSTANCE(pThis), pThis->VPCI.uStatus));
+        return;
+    }
+
+    if (!vnetR3IsConnected(pDevIns))
+    {
+        Log(("%s Ignoring transmit requests while cable is disconnected.\n", INSTANCE(pThis)));
+        return;
+    }
+
+    /*
      * Only one thread is allowed to transmit at a time, others should skip
      * transmission as the packets will be picked up by the transmitting
@@ -1358 +1374 @@
     if (!ASMAtomicCmpXchgU32(&pThis->uIsTransmitting, 1, 0))
         return;
-
-    if ((pThis->VPCI.uStatus & VPCI_STATUS_DRV_OK) == 0)
-    {
-        Log(("%s Ignoring transmit requests from non-existent driver (status=0x%x).\n", INSTANCE(pThis), pThis->VPCI.uStatus));
-        return;
-    }
-
-    if (!vnetR3IsConnected(pDevIns))
-    {
-        Log(("%s Ignoring transmit requests while cable is disconnected.\n", INSTANCE(pThis)));
-        return;
-    }
 
     PPDMINETWORKUP pDrv = pThisCC->pDrv;