Changeset 90175 in vbox for trunk/include/VBox

Timestamp:

Jul 14, 2021 8:48:27 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145691

Message:

Network: (bugref:10024) Fixed UDP header handling when carving segments destructively.

File:

• trunk/include/VBox/vmm/pdmnetinline.h (modified) (1 diff)

trunk/include/VBox/vmm/pdmnetinline.h

@@ -414 +414 @@
      * Figure out where the payload is and where the header starts before we
      * do the protocol specific carving.
+     *
+     * UDP GSO uses IPv4 fragmentation, meaning that UDP header is present in
+     * the first fragment only. When computing the total frame size of the
+     * first fragment we need to use PDMNETWORKGSO::cbHdrsTotal instead of
+     * PDMNETWORKGSO::cbHdrsSeg. In case of TCP GSO both cbHdrsTotal and
+     * cbHdrsSeg have the same value, so it will work as well.
      */
     uint8_t * const pbSegHdrs    = pbFrame + pGso->cbMaxSeg * iSeg;
     uint8_t * const pbSegPayload = pbSegHdrs + pGso->cbHdrsSeg;
     uint32_t const  cbSegPayload = pdmNetSegPayloadLen(pGso, iSeg, cSegs, (uint32_t)cbFrame);
-    uint32_t const  cbSegFrame   = cbSegPayload + pGso->cbHdrsSeg;
+    uint32_t const  cbSegFrame   = cbSegPayload + (iSeg ? pGso->cbHdrsSeg : pGso->cbHdrsTotal);
 
     /*