Changeset 90188 in vbox for trunk/src/VBox/Additions/WINNT/Graphics/Video

Timestamp:

Jul 14, 2021 3:51:42 PM (3 years ago)

Author:

vboxsync

Message:

3D/VMSVGA: Parameters validation during command buffer context init/cleanup, bugref:9845

Location:

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium

Files:

• Svga.cpp (modified) (2 diffs)
• Svga.h (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium/Svga.cpp

@@ -31 +31 @@
     int rc = STATUS_SUCCESS;
 
+    AssertReturn(enable == (pSvga->hMemObj == NIL_RTR0MEMOBJ), STATUS_INVALID_PARAMETER);
+
     if (enable)
     {
@@ -64 +66 @@
     if (!enable)
     {
-        RTR0MemObjFree(pSvga->hMemObj, true);
+        rc = RTR0MemObjFree(pSvga->hMemObj, true);
         pSvga->hMemObj = NIL_RTR0MEMOBJ;
     }
 
+    AssertRC(rc);
     return rc;
 }

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium/Svga.h

@@ -65 +65 @@
     volatile uint32_t *pu32FIFO;
 
+    /** Used only with SVGA_CAP_COMMAND_BUFFERS capability. */
     RTR0MEMOBJ hMemObj;
     RTR0PTR  pvR0Hdr, pvR0Cmd;