Changeset 90241 in vbox for trunk/src/VBox

Timestamp:

Jul 19, 2021 2:28:35 PM (4 years ago)

Author:

vboxsync

Message:

DrvKeyboardQueue: Fixed Korean key detection (I think), added assertion for keys that have no translation and produce zero usage code.

File:

• trunk/src/VBox/Devices/Input/DrvKeyboardQueue.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Input/DrvKeyboardQueue.cpp

@@ -163 +163 @@
         } else {
             usage = aScancode2Hid[scanCode & 0x7F];
+            AssertMsg(usage, ("SS_IDLE: scanCode=%02X\n", scanCode));
             *pUsage = usage | keyUp | HID_PG_KB_BITS;
             /* Remain in SS_IDLE state. */
@@ -169 +170 @@
     case SS_EXT:
         usage = aExtScan2Hid[scanCode & 0x7F];
+        AssertMsg(usage, ("SS_EXT: scanCode=%02X\n", scanCode));
         *pUsage = usage | keyUp | HID_PG_KB_BITS;
         state = SS_IDLE;
@@ -238 +240 @@
              * key up into a key up/key down sequence.
              */
-            if ((idUsage == (PDMIKBDPORT_KEY_UP | 0x90)) || (idUsage == (PDMIKBDPORT_KEY_UP | 0x91)))
+            if (   (idUsage == (PDMIKBDPORT_KEY_UP | HID_PG_KB_BITS | 0x90))
+                || (idUsage == (PDMIKBDPORT_KEY_UP | HID_PG_KB_BITS | 0x91)))
             {
                 PDRVKBDQUEUEITEM pItem2 = (PDRVKBDQUEUEITEM)PDMQueueAlloc(pDrv->pQueue);