Changeset 90332 in vbox

Timestamp:

Jul 26, 2021 12:57:23 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145895

Message:

Dev*: Use PDMCritSect API via PDMDevHlp. bugref:10074

Location:

trunk/src/VBox/Devices

Files:

• Network/DevE1000.cpp (modified) (1 diff)
• PC/DevIoApic.cpp (modified) (1 diff)
• Parallel/DevParallel.cpp (modified) (1 diff)
• Serial/UartCore.cpp (modified) (4 diffs)
• USB/DevOHCI.cpp (modified) (1 diff)
• VMMDev/VMMDev.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -3564 +3564 @@
 {
     PE1KSTATE pThis = (PE1KSTATE)pvUser;
-    Assert(PDMCritSectIsOwner(&pThis->csTx));
+    Assert(PDMDevHlpCritSectIsOwner(pDevIns, &pThis->csTx));
     RT_NOREF(hTimer);
 

trunk/src/VBox/Devices/PC/DevIoApic.cpp

@@ -1530 +1530 @@
      * Destroy the RTE critical section.
      */
-    if (PDMCritSectIsInitialized(&pThis->CritSect))
-        PDMR3CritSectDelete(&pThis->CritSect);
+    if (PDMDevHlpCritSectIsInitialized(pDevIns, &pThis->CritSect))
+        PDMDevHlpCritSectDelete(pDevIns, &pThis->CritSect);
 # else
     RT_NOREF_PV(pThis);

trunk/src/VBox/Devices/Parallel/DevParallel.cpp

@@ -304 +304 @@
     PPARALLELPORT   pThis   = PDMDEVINS_2_DATA(pDevIns, PPARALLELPORT);
 
-    PDMCritSectEnter(pDevIns->pCritSectRoR3, VINF_SUCCESS);
+    PDMDevHlpCritSectEnter(pDevIns, pDevIns->pCritSectRoR3, VINF_SUCCESS);
     parallelR3IrqSet(pDevIns, pThis);
-    PDMCritSectLeave(pDevIns->pCritSectRoR3);
+    PDMDevHlpCritSectLeave(pDevIns, pDevIns->pCritSectRoR3);
 
     return VINF_SUCCESS;

trunk/src/VBox/Devices/Serial/UartCore.cpp

@@ -1632 +1632 @@
 
     /* Set the transmitter empty bit because everything was sent. */
-    PDMCritSectEnter(&pThis->CritSect, VERR_IGNORED);
+    PDMDevHlpCritSectEnter(pDevIns, &pThis->CritSect, VERR_IGNORED);
     UART_REG_SET(pThis->uRegLsr, UART_REG_LSR_TEMT);
     uartIrqUpdate(pDevIns, pThis, pThisCC);
-    PDMCritSectLeave(&pThis->CritSect);
+    PDMDevHlpCritSectLeave(pDevIns, &pThis->CritSect);
     return VINF_SUCCESS;
 }
@@ -1652 +1652 @@
     AssertReturn(cbRead > 0, VERR_INVALID_PARAMETER);
 
-    PDMCritSectEnter(&pThis->CritSect, VERR_IGNORED);
+    PDMDevHlpCritSectEnter(pDevIns, &pThis->CritSect, VERR_IGNORED);
     uartR3TxQueueCopyFrom(pDevIns, pThis, pThisCC, pvBuf, cbRead, pcbRead);
-    PDMCritSectLeave(&pThis->CritSect);
+    PDMDevHlpCritSectLeave(pDevIns, &pThis->CritSect);
 
     LogFlowFunc(("-> VINF_SUCCESS{*pcbRead=%zu}\n", *pcbRead));
@@ -1671 +1671 @@
     PPDMDEVINS  pDevIns = pThisCC->pDevIns;
 
-    PDMCritSectEnter(&pThis->CritSect, VERR_IGNORED);
+    PDMDevHlpCritSectEnter(pDevIns, &pThis->CritSect, VERR_IGNORED);
     uartR3StsLinesUpdate(pDevIns, pThis, pThisCC, fNewStatusLines);
-    PDMCritSectLeave(&pThis->CritSect);
+    PDMDevHlpCritSectLeave(pDevIns, &pThis->CritSect);
     return VINF_SUCCESS;
 }
@@ -1688 +1688 @@
     PPDMDEVINS  pDevIns = pThisCC->pDevIns;
 
-    PDMCritSectEnter(&pThis->CritSect, VERR_IGNORED);
+    PDMDevHlpCritSectEnter(pDevIns, &pThis->CritSect, VERR_IGNORED);
     UART_REG_SET(pThis->uRegLsr, UART_REG_LSR_BI);
     uartIrqUpdate(pDevIns, pThis, pThisCC);
-    PDMCritSectLeave(&pThis->CritSect);
+    PDMDevHlpCritSectLeave(pDevIns, &pThis->CritSect);
     return VINF_SUCCESS;
 }

trunk/src/VBox/Devices/USB/DevOHCI.cpp

@@ -6024 +6024 @@
     if (RTCritSectIsInitialized(&pThisCC->CritSect))
         RTCritSectDelete(&pThisCC->CritSect);
-    PDMR3CritSectDelete(&pThis->CsIrq);
+    PDMDevHlpCritSectDelete(pDevIns, &pThis->CsIrq);
 
     /*

trunk/src/VBox/Devices/VMMDev/VMMDev.cpp

@@ -316 +316 @@
 {
     Log3(("vmmdevNotifyGuestWorker: fAddEvents=%#010x.\n", fAddEvents));
-    Assert(PDMCritSectIsOwner(&pThis->CritSect));
+    Assert(PDMDevHlpCritSectIsOwner(pDevIns, &pThis->CritSect));
 
     if (!VMMDEV_INTERFACE_VERSION_IS_1_03(pThis))
@@ -3183 +3183 @@
                 else
                 {
-                    Log(("vmmdevFastRequestHandler: PDMCritSectEnter -> %Rrc\n", rc2));
+                    Log(("vmmdevFastRequestHandler: PDMDevHlpPDMCritSectEnter -> %Rrc\n", rc2));
                     rcStrict = rc2;
                 }