Changeset 90362 in vbox for trunk/src

Timestamp:

Jul 27, 2021 6:00:18 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145935

Message:

FE/Qt: bugref:9996. Working on new vd wizard. it is still broken

Location:

trunk/src/VBox/Frontends/VirtualBox/src/wizards

Files:

• editors/UIWizardDiskEditors.cpp (modified) (10 diffs)
• editors/UIWizardDiskEditors.h (modified) (7 diffs)
• newvd/UIWizardNewVD.cpp (modified) (1 diff)
• newvd/UIWizardNewVDPageSizeLocation.cpp (modified) (3 diffs)
• newvd/UIWizardNewVDPageVariant.cpp (modified) (1 diff)
• newvm/UIWizardNewVMPageExpert.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIWizardDiskEditors.cpp

@@ -28 +28 @@
 #include "QILineEdit.h"
 #include "QIToolButton.h"
+#include "QIRichTextLabel.h"
 #include "UICommon.h"
 #include "UIConverter.h"
@@ -43 +44 @@
 #include "CSystemProperties.h"
 
+
+/*********************************************************************************************************************************
+*   UIDiskEditorGroupBox implementation.                                                                                   *
+*********************************************************************************************************************************/
+
+UIDiskEditorGroupBox::UIDiskEditorGroupBox(bool fExpertMode, QWidget *pParent /* = 0 */)
+    : QIWithRetranslateUI<QGroupBox>(pParent)
+    , m_fExpertMode(fExpertMode)
+{
+    if (!m_fExpertMode)
+        setFlat(true);
+}
+
 /*********************************************************************************************************************************
 *   UIDiskFormatsGroupBox implementation.                                                                                   *
@@ -48 +62 @@
 
 UIDiskFormatsGroupBox::UIDiskFormatsGroupBox(bool fExpertMode, QWidget *pParent /* = 0 */)
-    : QIWithRetranslateUI<QGroupBox>(pParent)
+    : UIDiskEditorGroupBox(fExpertMode, pParent)
     , m_pFormatButtonGroup(0)
-    , m_fExpertMode(fExpertMode)
 {
     prepare();
@@ -78 +91 @@
 {
     QVBoxLayout *pContainerLayout = new QVBoxLayout(this);
-    if (!m_fExpertMode)
-        setFlat(true);
 
     m_pFormatButtonGroup = new QButtonGroup;
@@ -212 +223 @@
 
 UIDiskVariantGroupBox::UIDiskVariantGroupBox(bool fExpertMode, QWidget *pParent /* = 0 */)
-    : QIWithRetranslateUI<QGroupBox>(pParent)
+    : UIDiskEditorGroupBox(fExpertMode, pParent)
     , m_pFixedCheckBox(0)
     , m_pSplitBox(0)
-    , m_fExpertMode(fExpertMode)
 {
     prepare();
@@ -222 +232 @@
 void UIDiskVariantGroupBox::prepare()
 {
-    if (!m_fExpertMode)
-        setFlat(true);
     QVBoxLayout *pVariantLayout = new QVBoxLayout(this);
     AssertReturnVoid(pVariantLayout);
@@ -353 +361 @@
 *********************************************************************************************************************************/
 
-UIMediumSizeAndPathGroupBox::UIMediumSizeAndPathGroupBox(QWidget *pParent /* = 0 */)
-    : QIWithRetranslateUI<QGroupBox>(pParent)
-    , m_pLocationLabel(0)
+UIMediumSizeAndPathGroupBox::UIMediumSizeAndPathGroupBox(bool fExpertMode, QWidget *pParent /* = 0 */)
+    : UIDiskEditorGroupBox(fExpertMode, pParent)
     , m_pLocationEditor(0)
     , m_pLocationOpenButton(0)
-    , m_pMediumSizeEditorLabel(0)
     , m_pMediumSizeEditor(0)
+    , m_pLocationLabel(0)
+    , m_pSizeLabel(0)
 {
     prepare();
@@ -366 +374 @@
 void UIMediumSizeAndPathGroupBox::prepare()
 {
-    QGridLayout *pDiskContainerLayout = new QGridLayout(this);
-
-    /* Disk location widgets: */
-    m_pLocationLabel = new QLabel;
-    m_pLocationLabel->setSizePolicy(QSizePolicy::Maximum, QSizePolicy::Fixed);
+    QVBoxLayout *pMainLayout = new QVBoxLayout(this);
+    /* Location widgets: */
+    if (!m_fExpertMode)
+        m_pLocationLabel = new QIRichTextLabel;
+    QHBoxLayout *pLocationLayout = new QHBoxLayout;
     m_pLocationEditor = new QILineEdit;
     m_pLocationOpenButton = new QIToolButton;
@@ -378 +386 @@
         m_pLocationOpenButton->setIcon(UIIconPool::iconSet(":/select_file_16px.png", "select_file_disabled_16px.png"));
     }
-    m_pLocationLabel->setBuddy(m_pLocationEditor);
-
-    /* Disk file size widgets: */
-    m_pMediumSizeEditorLabel = new QLabel;
-    m_pMediumSizeEditorLabel->setAlignment(Qt::AlignRight);
-    m_pMediumSizeEditorLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
+    pLocationLayout->addWidget(m_pLocationEditor);
+    pLocationLayout->addWidget(m_pLocationOpenButton);
+
+    /* Size widgets: */
+    if (!m_fExpertMode)
+        m_pSizeLabel = new QIRichTextLabel;
     m_pMediumSizeEditor = new UIMediumSizeEditor;
-    m_pMediumSizeEditorLabel->setBuddy(m_pMediumSizeEditor);
-
-    pDiskContainerLayout->addWidget(m_pLocationLabel, 0, 0, 1, 1);
-    pDiskContainerLayout->addWidget(m_pLocationEditor, 0, 1, 1, 2);
-    pDiskContainerLayout->addWidget(m_pLocationOpenButton, 0, 3, 1, 1);
-
-    pDiskContainerLayout->addWidget(m_pMediumSizeEditorLabel, 1, 0, 1, 1, Qt::AlignBottom);
-    pDiskContainerLayout->addWidget(m_pMediumSizeEditor, 1, 1, 2, 3);
+
+    /* Add widgets to main layout: */
+    if (m_pLocationLabel)
+        pMainLayout->addWidget(m_pLocationLabel);
+    pMainLayout->addLayout(pLocationLayout);
+
+    if (m_pSizeLabel)
+        pMainLayout->addWidget(m_pSizeLabel);
+    pMainLayout->addWidget(m_pMediumSizeEditor);
 
     connect(m_pMediumSizeEditor, &UIMediumSizeEditor::sigSizeChanged,
@@ -407 +416 @@
 void UIMediumSizeAndPathGroupBox::retranslateUi()
 {
-    setTitle(tr("Hard Disk File Location and Size"));
+    if (m_fExpertMode)
+        setTitle(tr("Hard Disk File Location and Size"));
     if (m_pLocationOpenButton)
         m_pLocationOpenButton->setToolTip(tr("Choose a location for new virtual hard disk file..."));
+
+    if (!m_fExpertMode && m_pLocationLabel)
+        m_pLocationLabel->setText(tr("Please type the name of the new virtual hard disk file into the box below or "
+                                                    "click on the folder icon to select a different folder to create the file in."));
+    if (!m_fExpertMode && m_pSizeLabel)
+        m_pSizeLabel->setText(tr("Select the size of the virtual hard disk in megabytes. "
+                                                "This size is the limit on the amount of file data "
+                                                "that a virtual machine will be able to store on the hard disk."));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIWizardDiskEditors.h

@@ -37 +37 @@
 class QLabel;
 class QVBoxLayout;
+class QIRichTextLabel;
 class QILineEdit;
 class QIToolButton;
@@ -49 +50 @@
 #include "CMediumFormat.h"
 
-class SHARED_LIBRARY_STUFF UIDiskFormatsGroupBox : public QIWithRetranslateUI<QGroupBox>
+class SHARED_LIBRARY_STUFF UIDiskEditorGroupBox : public QIWithRetranslateUI<QGroupBox>
+{
+    Q_OBJECT;
+
+public:
+
+    UIDiskEditorGroupBox(bool fExpertMode, QWidget *pParent = 0);
+
+protected:
+
+    bool m_fExpertMode;
+};
+
+class SHARED_LIBRARY_STUFF UIDiskFormatsGroupBox : public UIDiskEditorGroupBox
 {
     Q_OBJECT;
@@ -78 +92 @@
     QStringList m_formatExtensions;
     QButtonGroup *m_pFormatButtonGroup;
-    bool m_fExpertMode;
 };
 
-class SHARED_LIBRARY_STUFF UIDiskVariantGroupBox : public QIWithRetranslateUI<QGroupBox>
+class SHARED_LIBRARY_STUFF UIDiskVariantGroupBox : public UIDiskEditorGroupBox
 {
     Q_OBJECT;
@@ -109 +122 @@
     QCheckBox *m_pFixedCheckBox;
     QCheckBox *m_pSplitBox;
-    bool m_fExpertMode;
 };
 
 
-class SHARED_LIBRARY_STUFF UIMediumSizeAndPathGroupBox : public QIWithRetranslateUI<QGroupBox>
+class SHARED_LIBRARY_STUFF UIMediumSizeAndPathGroupBox : public UIDiskEditorGroupBox
 {
     Q_OBJECT;
@@ -125 +137 @@
 public:
 
-    UIMediumSizeAndPathGroupBox(QWidget *pParent = 0);
-
+    UIMediumSizeAndPathGroupBox(bool fExpertMode, QWidget *pParent = 0);
     QString mediumPath() const;
     void setMediumPath(const QString &strMediumPath);
@@ -132 +143 @@
     qulonglong mediumSize() const;
     void setMediumSize(qulonglong uSize);
-
 
 private:
@@ -141 +151 @@
                                         const QStringList &formatExtensions);
 
-
-    QLabel *m_pLocationLabel;
     QILineEdit *m_pLocationEditor;
     QIToolButton *m_pLocationOpenButton;
-    QLabel *m_pMediumSizeEditorLabel;
     UIMediumSizeEditor *m_pMediumSizeEditor;
+    QIRichTextLabel *m_pLocationLabel;
+    QIRichTextLabel *m_pSizeLabel;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvd/UIWizardNewVD.cpp

@@ -63 +63 @@
             addPage(new UIWizardNewVDPageFileType);
             addPage(new UIWizardNewVDPageVariant);
+            addPage(new UIWizardNewVDPageSizeLocation(m_strDefaultName, m_strDefaultPath, m_uDefaultSize));
             break;
         }

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvd/UIWizardNewVDPageSizeLocation.cpp

@@ -300 +300 @@
     QVBoxLayout *pMainLayout = new QVBoxLayout(this);
     AssertReturnVoid(pMainLayout);
+    m_pMediumSizePathGroup = new UIMediumSizeAndPathGroupBox(false, 0);
 //     {
 //         m_pLocationLabel = new QIRichTextLabel(this);
@@ -319 +320 @@
 //         pMainLayout->addLayout(pLocationLayout);
 //         pMainLayout->addWidget(m_pSizeLabel);
-//         pMainLayout->addWidget(m_pMediumSizeEditor);
-//         pMainLayout->addStretch();
+    pMainLayout->addWidget(m_pMediumSizePathGroup);
+    pMainLayout->addStretch();
 //     }
     retranslateUi();
@@ -334 +335 @@
 {
     setTitle(UIWizardNewVD::tr("File location and size"));
-    // if (m_pLocationLabel)
-    //     m_pLocationLabel->setText(UIWizardNewVD::tr("Please type the name of the new virtual hard disk file into the box below or "
-    //                                                 "click on the folder icon to select a different folder to create the file in."));
-    // if (m_pSizeLabel)
-    //     m_pSizeLabel->setText(UIWizardNewVD::tr("Select the size of the virtual hard disk in megabytes. "
-    //                                             "This size is the limit on the amount of file data "
-    //                                             "that a virtual machine will be able to store on the hard disk."));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvd/UIWizardNewVDPageVariant.cpp

@@ -233 +233 @@
 {
     //return mediumVariant() != (qulonglong)KMediumVariant_Max;
-    return false;
-}
+    return true;
+}

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMPageExpert.cpp

@@ -464 +464 @@
     QGridLayout *pDiskContainerLayout = new QGridLayout(pNewDiskContainerWidget);
 
-    m_pSizeAndLocationGroup = new UIMediumSizeAndPathGroupBox;
+    m_pSizeAndLocationGroup = new UIMediumSizeAndPathGroupBox(true, 0);
     pDiskContainerLayout->addWidget(m_pSizeAndLocationGroup, 0, 0, 2, 2);
     m_pFormatButtonGroup = new UIDiskFormatsGroupBox(true, 0);