Changeset 90392 in vbox

Timestamp:

Jul 29, 2021 8:25:50 AM (3 years ago)

Author:

vboxsync

Message:

IPRT/RTThreadCreate: Added RTTHREADFLAGS_NO_SIGNALS (posix only). bugref:6695

Location:

trunk

Files:

• include/iprt/thread.h (modified) (1 diff)
• src/VBox/Runtime/r3/posix/thread-posix.cpp (modified) (6 diffs)

trunk/include/iprt/thread.h

@@ -261 +261 @@
      *  COINIT_SPEED_OVER_MEMORY.   Ignored on non-windows platforms.  */
     RTTHREADFLAGS_COM_STA = RT_BIT(2),
+
+    /** Mask all signals that we can mask.  Ignored on most non-posix platforms.
+     * @note RTThreadPoke() will not necessarily work for a thread create with
+     *       this flag. */
+    RTTHREADFLAGS_NO_SIGNALS = RT_BIT(3),
 
     /** Mask of valid flags, use for validation. */

trunk/src/VBox/Runtime/r3/posix/thread-posix.cpp

@@ -238 +238 @@
 }
 
-static void rtThreadPosixBlockSignals(void)
-{
+static void rtThreadPosixBlockSignals(PRTTHREADINT pThread)
+{
+    /*
+     * Mask all signals, including the poke one, if requested.
+     */
+    if (   pThread
+        && (pThread->fFlags & RTTHREADFLAGS_NO_SIGNALS))
+    {
+        sigset_t SigSet;
+        sigfillset(&SigSet);
+        int rc = sigprocmask(SIG_BLOCK, &SigSet, NULL);
+        AssertMsg(rc == 0, ("rc=%Rrc errno=%d\n", RTErrConvertFromErrno(errno), errno)); RT_NOREF(rc);
+    }
     /*
      * Block SIGALRM - required for timer-posix.cpp.
@@ -245 +256 @@
      * It will not help much if someone creates threads directly using pthread_create. :/
      */
-    if (!RTR3InitIsUnobtrusive())
+    else if (!RTR3InitIsUnobtrusive())
     {
         sigset_t SigSet;
@@ -255 +266 @@
 #ifdef RTTHREAD_POSIX_WITH_POKE
     /*
-     * bird 2020-10-28: Not entirely sure we do this, but it makes sure the signal works
+     * bird 2020-10-28: Not entirely sure why we do this, but it makes sure the signal works
      *                  on the new thread.  Probably some pre-NPTL linux reasons.
      */
@@ -286 +297 @@
     rtThreadPosixSelectPokeSignal();
 #endif
-    rtThreadPosixBlockSignals();
+    rtThreadPosixBlockSignals(NULL);
 }
 
@@ -331 +342 @@
 DECLHIDDEN(int) rtThreadNativeAdopt(PRTTHREADINT pThread)
 {
-    rtThreadPosixBlockSignals();
+    rtThreadPosixBlockSignals(pThread);
 
     int rc = pthread_setspecific(g_SelfKey, pThread);
@@ -367 +378 @@
 #endif
 
-    rtThreadPosixBlockSignals();
+    rtThreadPosixBlockSignals(pThread);
 
     /*