Changeset 90554 in vbox

Timestamp:

Aug 6, 2021 3:40:59 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146160

Message:

Audio/ValKit: Init crit sect in atsTcpCreate() to match its destruction in atsTcpDestroy(). bugref:10008

File:

• trunk/src/VBox/Devices/Audio/AudioTestServiceTcp.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/AudioTestServiceTcp.cpp

@@ -699 +699 @@
     AssertPtrReturn(pThis, VERR_NO_MEMORY);
 
-    *ppThis = pThis;
-    return VINF_SUCCESS;
+    int rc = RTCritSectInit(&pThis->CritSect);
+    if (RT_SUCCESS(rc))
+    {
+        *ppThis = pThis;
+    }
+
+    return rc;
 }
 
@@ -722 +727 @@
 static DECLCALLBACK(int) atsTcpStart(PATSTRANSPORTINST pThis)
 {
-    int rc = RTCritSectInit(&pThis->CritSect);
-    if (RT_SUCCESS(rc) && pThis->enmMode != ATSTCPMODE_CLIENT)
+    int rc = VINF_SUCCESS;
+
+    if (pThis->enmMode != ATSTCPMODE_CLIENT)
     {
         rc = RTTcpServerCreateEx(pThis->szBindAddr[0] ? pThis->szBindAddr : NULL, pThis->uBindPort, &pThis->pTcpServer);