Changeset 90600 in vbox

Timestamp:

Aug 10, 2021 3:13:39 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10067: Open notification-center on object append only if it's critical.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter

Files:

• UINotificationCenter.cpp (modified) (1 diff)
• UINotificationObject.cpp (modified) (2 diffs)
• UINotificationObject.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationCenter.cpp

@@ -171 +171 @@
 QUuid UINotificationCenter::append(UINotificationObject *pObject)
 {
-    /* Open if not yet: */
-    if (!m_pOpenButton->isChecked())
+    AssertPtrReturn(m_pModel, QUuid());
+    const QUuid uId = m_pModel->appendObject(pObject);
+
+    /* Open if object is critical and center isn't opened yet: */
+    if (!m_pOpenButton->isChecked() && pObject->isCritical())
         m_pOpenButton->animateClick();
 
-    AssertPtrReturn(m_pModel, QUuid());
-    return m_pModel->appendObject(pObject);
+    return uId;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObject.cpp

@@ -69 +69 @@
 }
 
+bool UINotificationProgress::isCritical() const
+{
+    return true;
+}
+
 void UINotificationProgress::handle()
 {
@@ -135 +140 @@
 }
 
+bool UINotificationDownloader::isCritical() const
+{
+    return true;
+}
+
 void UINotificationDownloader::handle()
 {

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObject.h

@@ -53 +53 @@
     UINotificationObject();
 
+    /** Returns whether object is critical. */
+    virtual bool isCritical() const = 0;
     /** Returns object name. */
     virtual QString name() const = 0;
@@ -98 +100 @@
     QString error() const;
 
+    /** Returns whether object is critical. */
+    virtual bool isCritical() const;
     /** Handles notification-object being added. */
     virtual void handle() /* override final */;
@@ -161 +165 @@
     QString error() const;
 
+    /** Returns whether object is critical. */
+    virtual bool isCritical() const;
     /** Handles notification-object being added. */
     virtual void handle() /* override final */;