Changeset 90604 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Aug 10, 2021 3:30:02 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10067: Extend UINewVersionChecker with signals to distinguish canceled and failed requests from one finished successfully.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/networking

Files:

• UINewVersionChecker.cpp (modified) (2 diffs)
• UINewVersionChecker.h (modified) (1 diff)
• UIUpdateManager.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/networking/UINewVersionChecker.cpp

@@ -84 +84 @@
 }
 
-void UINewVersionChecker::processNetworkReplyFailed(const QString &)
+void UINewVersionChecker::processNetworkReplyFailed(const QString &strError)
 {
-    emit sigNewVersionChecked();
+    emit sigProgressFailed(strError);
 }
 
 void UINewVersionChecker::processNetworkReplyCanceled(UINetworkReply *)
 {
-    emit sigNewVersionChecked();
+    emit sigProgressCanceled();
 }
 
@@ -119 +119 @@
 
     /* Notify about completion: */
-    emit sigNewVersionChecked();
+    emit sigProgressFinished();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/networking/UINewVersionChecker.h

@@ -33 +33 @@
 signals:
 
-    /** Notifies about new version check complete. */
-    void sigNewVersionChecked();
+    /** Notifies listeners about progress failed with @a strError. */
+    void sigProgressFailed(const QString &strError);
+    /** Notifies listeners about progress canceled. */
+    void sigProgressCanceled();
+    /** Notifies listeners about progress finished. */
+    void sigProgressFinished();
 
 public:

trunk/src/VBox/Frontends/VirtualBox/src/networking/UIUpdateManager.cpp

@@ -93 +93 @@
     m_pNewVersionChecker = new UINewVersionChecker(fForcedCall);
     if (m_pNewVersionChecker)
-        connect(m_pNewVersionChecker, &UINewVersionChecker::sigNewVersionChecked,
+    {
+        connect(m_pNewVersionChecker, &UINewVersionChecker::sigProgressFailed,
                 this, &UIUpdateStepVirtualBox::sigStepFinished);
+        connect(m_pNewVersionChecker, &UINewVersionChecker::sigProgressCanceled,
+                this, &UIUpdateStepVirtualBox::sigStepFinished);
+        connect(m_pNewVersionChecker, &UINewVersionChecker::sigProgressFinished,
+                this, &UIUpdateStepVirtualBox::sigStepFinished);
+    }
 }