Changeset 90624 in vbox for trunk/src/VBox/Additions/x11/VBoxClient

Timestamp:

Aug 11, 2021 12:31:27 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146235

Message:

Additions: X11: VBoxSVGA: prevent fatal error notification flooding, bugref:10028.

At some circumstances, VbglR3GetDisplayChangeRequestMulti(), which is called in a loop,
might fail. This will trigger VBClLogFatalError() call which, in turn, will trigger
notification popup on a guest side for some desktop environments. If
VbglR3GetDisplayChangeRequestMulti() will constantly fail, it will result
in popup notification flooding. This commit replaces VBClLogFatalError() with VBClLogError()
in order to prevent it.

Location:

trunk/src/VBox/Additions/x11/VBoxClient

Files:

• display-drm.cpp (modified) (1 diff)
• display-svga-x11.cpp (modified) (1 diff)

trunk/src/VBox/Additions/x11/VBoxClient/display-drm.cpp

@@ -226 +226 @@
         fAck = true;
         if (RT_FAILURE(rc))
-            VBClLogFatalError("Failed to get display change request, rc=%Rrc\n", rc);
+            VBClLogError("Failed to get display change request, rc=%Rrc\n", rc);
         if (cDisplaysOut > VMW_MAX_HEADS)
-            VBClLogFatalError("Display change request contained, rc=%Rrc\n", rc);
+            VBClLogError("Display change request contained, rc=%Rrc\n", rc);
         if (cDisplaysOut > 0)
         {

trunk/src/VBox/Additions/x11/VBoxClient/display-svga-x11.cpp

@@ -1388 +1388 @@
         fAck = true;
         if (RT_FAILURE(rc))
-            VBClLogFatalError("Failed to get display change request, rc=%Rrc\n", rc);
+            VBClLogError("Failed to get display change request, rc=%Rrc\n", rc);
         if (cDisplaysOut > VMW_MAX_HEADS)
-            VBClLogFatalError("Display change request contained, rc=%Rrc\n", rc);
+            VBClLogError("Display change request contained, rc=%Rrc\n", rc);
         if (cDisplaysOut > 0)
         {