Changeset 90633 in vbox

Timestamp:

Aug 11, 2021 6:25:25 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: Fixing a paint bug causing an infinite paint loop.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/extensions/QILineEdit.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/extensions/QILineEdit.cpp

@@ -24 +24 @@
 #include <QPalette>
 #include <QStyleOptionFrame>
+#include <QTime>
 
 /* GUI includes: */
@@ -100 +101 @@
 void QILineEdit::paintEvent(QPaintEvent *pPaintEvent)
 {
+    printf("%d\n", QTime::currentTime().second());
     QLineEdit::paintEvent(pPaintEvent);
 
     if (m_fMarkForError)
     {
-        const int iIconMargin = 1. * QApplication::style()->pixelMetric(QStyle::PM_LayoutTopMargin);
-        int iIconSize = height() - 2 * iIconMargin;
         if (!m_pIconLabel)
             m_pIconLabel = new QLabel(this);
-        m_pIconLabel->setPixmap(m_markIcon.pixmap(windowHandle(), QSize(iIconSize, iIconSize)));
-        m_pIconLabel->setToolTip(m_strErrorMessage);
-        m_pIconLabel->move(width() - iIconSize - iIconMargin, iIconMargin);
-        m_pIconLabel->show();
+
+        if (m_pIconLabel && m_pIconLabel->isHidden())
+        {
+            const int iIconMargin = 1. * QApplication::style()->pixelMetric(QStyle::PM_LayoutTopMargin);
+            int iIconSize = height() - 2 * iIconMargin;
+            m_pIconLabel->setPixmap(m_markIcon.pixmap(windowHandle(), QSize(iIconSize, iIconSize)));
+            m_pIconLabel->setToolTip(m_strErrorMessage);
+            m_pIconLabel->move(width() - iIconSize - iIconMargin, iIconMargin);
+            m_pIconLabel->show();
+        }
     }
     else
     {
-        if (m_pIconLabel)
+        if (m_pIconLabel && m_pIconLabel->isVisible())
             m_pIconLabel->hide();
     }