Changeset 90644 in vbox for trunk/src/VBox/ValidationKit/tests

Timestamp:

Aug 12, 2021 7:37:31 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146256

Message:

Audio/ValKit: Don't use killall but grep'ing ps instead, as older Debians don't have killall out-of-the-box. Also should work on macOS [build fix]. ​bugref:10008

File:

• trunk/src/VBox/ValidationKit/tests/audio/tdAudioTest.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/tests/audio/tdAudioTest.py

@@ -214 +214 @@
             os.system('taskkill /IM "%s.exe" /F' % (sProcName));
         else: # Note: killall is not available on older Debians (requires psmisc).
-            procPs = subprocess.Popen(['ps', 'ax'], stdout=subprocess.PIPE); # Using the BSD syntax here; MacOS also should understand this.
+            # Using the BSD syntax here; MacOS also should understand this.
+            procPs = subprocess.Popen(['ps', 'ax'], stdout=subprocess.PIPE);
             out, _ = procPs.communicate();
             for sLine in out.decode("utf-8").splitlines():
@@ -220 +221 @@
                     pid = int(sLine.split(None, 1)[0]);
                     reporter.log2('Killing PID %d' % (pid,));
-                    os.kill(pid, signal.SIGKILL);
+                    os.kill(pid, signal.SIGKILL); # pylint: disable=no-member
 
     def killHstVkat(self):