Changeset 90646 in vbox

Timestamp:

Aug 12, 2021 10:11:37 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146258

Message:

Audio/ValKit: Added initial support to tdAudioTest.py to disable the guest and host firewalls to let VKAT / ATS through (and to not make the tests hang in such cases). ​bugref:10008

File:

• trunk/src/VBox/ValidationKit/tests/audio/tdAudioTest.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/tests/audio/tdAudioTest.py

@@ -51 +51 @@
 from testdriver import vbox
 from testdriver import vboxtestvms
+from common     import utils;
 
 # pylint: disable=unnecessary-semicolon
@@ -231 +232 @@
         self.killProcessByName("VBoxAudioTest");
 
+    def getWinFirewallArgsDisable(self, sOsType):
+        """
+        Returns the command line arguments for Windows OSes
+        to disable the built-in firewall (if any).
+
+        If not supported, returns an empty array.
+        """
+        if   sOsType == 'vista': # Vista and up.
+            return (['netsh', 'advfirewall', 'set', 'allprofiles', 'state', 'off']);
+        elif sOsType == 'xp':    # Older stuff (XP / 2003).
+            return(['netsh', 'firewall', 'set', 'opmode', 'mode=DISABLE']);
+        # Not supported / available.
+        return [];
+
+    def disableGstFirewall(self, oTestVm, oTxsSession):
+        """
+        Disables the firewall on a guest (if any).
+
+        Needs elevated / admin / root privileges.
+
+        Returns success status, not logged.
+        """
+        fRc = False;
+
+        asArgs  = [];
+        sOsType = '';
+        if oTestVm.isWindows():
+            if oTestVm.sKind in ['WindowsNT4', 'WindowsNT3x']:
+                sOsType = 'nt3x'; # Not supported, but define it anyway.
+            elif oTestVm.sKind in ('Windows2000', 'WindowsXP', 'Windows2003'):
+                sOsType = 'xp';
+            else:
+                sOsType = 'vista';
+            asArgs = self.getWinFirewallArgsDisable(sOsType);
+        else:
+            sOsType = 'unsupported';
+
+        reporter.log('Disabling firewall on guest (type: %s) ...' % (sOsType,));
+
+        if len(asArgs) > 0:
+            fRc = self.txsRunTest(oTxsSession, 'Disabling guest firewall', \
+                                  oTestVm.pathJoin(self.getGuestSystemDir(oTestVm), asArgs[0]), asArgs);
+            if not fRc:
+                reporter.error('Disabling firewall on guest returned exit code error %d' % (self.getLastRcFromTxs(oTxsSession)));
+        else:
+            reporter.log('Firewall not available on guest, skipping');
+            fRc = True; # Not available, just skip.
+
+        return fRc;
+
+    def disableHstFirewall(self):
+        """
+        Disables the firewall on the host (if any).
+
+        Needs elevated / admin / root privileges.
+
+        Returns success status, not logged.
+        """
+        fRc = False;
+
+        asArgs  = [];
+        sOsType = sys.platform;
+
+        if sOsType == 'win32':
+            reporter.log('Disabling firewall on host (type: %s) ...' % (sOsType));
+
+            ## @todo For now we ASSUME that we don't run (and don't support even) on old(er)
+            #        Windows hosts than Vista.
+            asArgs = self.getWinFirewallArgsDisable('vista');
+
+        if len(asArgs) > 0:
+            oProcess = utils.sudoProcessPopen(asArgs, stdout=subprocess.PIPE, stdin=subprocess.PIPE,
+                                              stderr=subprocess.PIPE, shell = False, close_fds = False);
+            if oProcess:
+                sOut, sErr = oProcess.communicate();
+
+                sOut = sOut.decode(sys.stdin.encoding);
+                for sLine in sOut.split('\n'):
+                    reporter.log(sLine);
+
+                sErr = sErr.decode(sys.stdin.encoding);
+                for sLine in sErr.split('\n'):
+                    reporter.log(sLine);
+
+                iExitCode  = oProcess.poll();
+                if iExitCode != 0:
+                    fRc = False;
+            else:
+                fRc = False;
+
+            if not fRc:
+                reporter.error('Disabling firewall on host returned exit code error %d' % iExitCode);
+        else:
+            reporter.log('Firewall not available on host, skipping ');
+            fRc = True; # Not available, just skip.
+
+        return fRc;
+
     def getLastRcFromTxs(self, oTxsSession):
         """
@@ -353 +452 @@
         Executes the specified audio tests.
         """
+
+        # Disable any OS-specific firewalls preventing VKAT / ATS to run.
+        self.disableHstFirewall();
+        self.disableGstFirewall(oTestVm, oTxsSession);
 
         # First try to kill any old VKAT / VBoxAudioTest processes lurking around on the host.