Changeset 9067 in vbox for trunk/src/VBox

Timestamp:

May 23, 2008 10:16:56 AM (17 years ago)

Author:

vboxsync

Message:

Frontends/VirtualBox and VirtualBox4: documented the mDoResize flag

Location:

trunk/src/VBox/Frontends

Files:

• VirtualBox/include/VBoxConsoleView.h (modified) (1 diff)
• VirtualBox/src/VBoxConsoleView.cpp (modified) (3 diffs)
• VirtualBox4/include/VBoxConsoleView.h (modified) (1 diff)
• VirtualBox4/src/VBoxConsoleView.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/include/VBoxConsoleView.h

@@ -239 +239 @@
     bool mIgnoreMainwndResize : 1;
     bool mAutoresizeGuest : 1;
+
+    /** 
+     * This flag indicates whether the last console resize should trigger
+     * a size hint to the guest.  This is important particularly when
+     * enabling the autoresize feature to know whether to send a hint.
+     */
     bool mDoResize : 1;
 

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp

@@ -1556 +1556 @@
             {
                 /* Set the "guest needs to resize" hint.  This hint is acted upon
-                 * when (and only when) the autoresize property is set to "true". */
+                 * when (and only when) the autoresize property is "true". */
                 mDoResize = mGuestSupportsGraphics || mMainWnd->isTrueFullscreen();
                 if (!mIgnoreMainwndResize &&
@@ -3558 +3558 @@
         if (!aToSize.isValid())
             sz -= QSize (frameWidth() * 2, frameWidth() * 2);
+        /* We only actually send the hint if
+         * 1) the autoresize property is set to true and
+         * 2) either an explicit new size was given (e.g. if the request
+         *    was triggered directly by a console resize event) or if no
+         *    explicit size was specified but a resize is flagged as being
+         *    needed (e.g. the autoresize was just enabled and the console
+         *    was resized while it was disabled). */
         if (mAutoresizeGuest &&
             (aToSize.isValid() || mDoResize))
@@ -3563 +3570 @@
             LogFlowFunc (("Will suggest %d x %d\n", sz.width(), sz.height()));
 
-            /* Increase the desktop geometry if needed */
+            /* Increase the maximum allowed size to the new size if needed */
             setDesktopGeoHint (sz.width(), sz.height());
 

trunk/src/VBox/Frontends/VirtualBox4/include/VBoxConsoleView.h

@@ -257 +257 @@
     bool mIgnoreMainwndResize : 1;
     bool mAutoresizeGuest : 1;
+
+    /**
+     * This flag indicates whether the last console resize should trigger
+     * a size hint to the guest.  This is important particularly when
+     * enabling the autoresize feature to know whether to send a hint.
+     */
     bool mDoResize : 1;
 

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxConsoleView.cpp

@@ -1603 +1603 @@
             {
                 /* Set the "guest needs to resize" hint.  This hint is acted upon
-                 * when (and only when) the autoresize property is set to "true". */
+                 * when (and only when) the autoresize property is "true". */
                 mDoResize = mGuestSupportsGraphics || mMainWnd->isTrueFullscreen();
                 if (!mIgnoreMainwndResize &&
@@ -3601 +3601 @@
         if (!aToSize.isValid())
             sz -= QSize (frameWidth() * 2, frameWidth() * 2);
+        /* We only actually send the hint if
+         * 1) the autoresize property is set to true and
+         * 2) either an explicit new size was given (e.g. if the request
+         *    was triggered directly by a console resize event) or if no
+         *    explicit size was specified but a resize is flagged as being
+         *    needed (e.g. the autoresize was just enabled and the console
+         *    was resized while it was disabled). */
         if (mAutoresizeGuest &&
             (aToSize.isValid() || mDoResize))
@@ -3606 +3613 @@
             LogFlowFunc (("Will suggest %d x %d\n", sz.width(), sz.height()));
 
-            /* Increase the desktop geometry if needed */
+            /* Increase the maximum allowed size to the new size if needed */
             setDesktopGeoHint (sz.width(), sz.height());