Changeset 90691 in vbox

Timestamp:

Aug 16, 2021 8:43:03 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146305

Message:

pdmifs: display reporting doxygen (brief + newline + detailed description) and parameter type+name.

Location:

trunk

Files:

• include/VBox/vmm/pdmifs.h (modified) (2 diffs)
• src/VBox/Main/include/DisplayImpl.h (modified) (1 diff)
• src/VBox/Main/src-client/DisplayImpl.cpp (modified) (1 diff)
• src/VBox/Main/src-client/VMMDevInterface.cpp (modified) (1 diff)

trunk/include/VBox/vmm/pdmifs.h

@@ -747 +747 @@
      * @param   cPositions      Number of monitor positions.
      * @param   paPositions     Monitor positions (offsets/origins) array.
-     * @thread  Any.
+     * @thread  Any (EMT).
+     * @sa      PDMIVMMDEVCONNECTOR::pfnUpdateMonitorPositions
      */
     DECLR3CALLBACKMEMBER(void, pfnReportMonitorPositions, (PPDMIDISPLAYPORT pInterface, uint32_t cPositions,
@@ -1868 +1869 @@
 
     /**
-     * Update monitor positions (offsets). Passing monitor positions from the guest to host
-     * exclusively since vmwgfx fails to do so (thru FIFO).
+     * Update monitor positions (offsets).
+     *
+     * Passing monitor positions from the guest to host exclusively since vmwgfx
+     * (linux driver) fails to do so thru the FIFO.
      *
      * @returns VBox status code.
      * @param   pInterface          Pointer to this interface.
      * @param   cPositions          Number of monitor positions
-     * @param   pPosition           Positions array
-     * @thread  The emulation thread.
-     *
+     * @param   paPositions         Positions array
      * @remarks Is allowed to be NULL.
-     */
-    DECLR3CALLBACKMEMBER(int, pfnUpdateMonitorPositions,(PPDMIVMMDEVCONNECTOR pInterface, uint32_t cPositions, PRTPOINT pPosition));
+     * @thread  The emulation thread.
+     * @sa      PDMIDISPLAYPORT::pfnReportMonitorPositions
+     */
+    DECLR3CALLBACKMEMBER(int, pfnUpdateMonitorPositions,(PPDMIVMMDEVCONNECTOR pInterface,
+                                                         uint32_t cPositions, PCRTPOINT paPositions));
 
     /**

trunk/src/VBox/Main/include/DisplayImpl.h

@@ -164 +164 @@
     int  i_saveVisibleRegion(uint32_t cRect, PRTRECT pRect);
     int  i_handleSetVisibleRegion(uint32_t cRect, PRTRECT pRect);
-    int  i_handleUpdateMonitorPositions(uint32_t cPositions, PRTPOINT pPosition);
+    int  i_handleUpdateMonitorPositions(uint32_t cPositions, PCRTPOINT paPositions);
     int  i_handleQueryVisibleRegion(uint32_t *pcRects, PRTRECT paRects);
 

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -1280 +1280 @@
 }
 
-int  Display::i_handleUpdateMonitorPositions(uint32_t cPositions, PRTPOINT pPosition)
-{
-    AssertMsgReturn(pPosition, ("Empty monitor position array\n"), E_INVALIDARG);
+int  Display::i_handleUpdateMonitorPositions(uint32_t cPositions, PCRTPOINT paPositions)
+{
+    AssertMsgReturn(paPositions, ("Empty monitor position array\n"), E_INVALIDARG);
     for (unsigned i = 0; i < cPositions; ++i)
         LogRel2(("Display::i_handleUpdateMonitorPositions: uScreenId=%d xOrigin=%d yOrigin=%dX\n",
-                 i, pPosition[i].x, pPosition[i].y));
+                 i, paPositions[i].x, paPositions[i].y));
 
     if (mpDrv && mpDrv->pUpPort->pfnReportMonitorPositions)
-        mpDrv->pUpPort->pfnReportMonitorPositions(mpDrv->pUpPort, cPositions, pPosition);
+        mpDrv->pUpPort->pfnReportMonitorPositions(mpDrv->pUpPort, cPositions, paPositions);
     return VINF_SUCCESS;
 }

trunk/src/VBox/Main/src-client/VMMDevInterface.cpp

@@ -461 +461 @@
 }
 
-DECLCALLBACK(int) vmmdevUpdateMonitorPositions(PPDMIVMMDEVCONNECTOR pInterface, uint32_t cPositions, PRTPOINT pPositions)
-{
-    PDRVMAINVMMDEV pDrv = RT_FROM_MEMBER(pInterface, DRVMAINVMMDEV, Connector);
-    Console *pConsole = pDrv->pVMMDev->getParent();
-
-    pConsole->i_getDisplay()->i_handleUpdateMonitorPositions(cPositions, pPositions);
+/**
+ * @interface_method_impl{PDMIVMMDEVCONNECTOR,pfnUpdateMonitorPositions}
+ */
+static DECLCALLBACK(int) vmmdevUpdateMonitorPositions(PPDMIVMMDEVCONNECTOR pInterface, uint32_t cPositions, PCRTPOINT paPositions)
+{
+    PDRVMAINVMMDEV pDrv = RT_FROM_MEMBER(pInterface, DRVMAINVMMDEV, Connector);
+    Console *pConsole = pDrv->pVMMDev->getParent();
+
+    pConsole->i_getDisplay()->i_handleUpdateMonitorPositions(cPositions, paPositions);
 
     return VINF_SUCCESS;