Changeset 90752 in vbox

Timestamp:

Aug 19, 2021 3:34:26 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10067: Clone VM wizard: Refactoring for r146358.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/wizards/clonevm/UIWizardCloneVM.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/clonevm/UIWizardCloneVM.cpp

@@ -168 +168 @@
         QUuid uSnapshotId;
         CProgress comProgress = comSessionMachine.TakeSnapshot(strSnapshotName, "", true, uSnapshotId);
-        if (comSessionMachine.isOk())
-        {
-            /* Make sure progress valid: */
+        if (!comSessionMachine.isOk())
+        {
+            msgCenter().cannotTakeSnapshot(comSessionMachine, strMachineName, this);
+            return false;
+        }
+        else
+        {
+            /* Make sure progress initially valid: */
             if (!comProgress.isNull() && !comProgress.GetCompleted())
             {
@@ -200 +205 @@
                 return false;
             }
-        }
-        else
-        {
-            msgCenter().cannotTakeSnapshot(comSessionMachine, strMachineName, this);
-            return false;
+            else
+            {
+                /* Look for created snapshot: */
+                const CSnapshot comCreatedSnapshot = m_machine.FindSnapshot(uSnapshotId.toString());
+                if (comCreatedSnapshot.isNull())
+                {
+                    msgCenter().cannotFindSnapshotByName(m_machine, strSnapshotName, this);
+                    return false;
+                }
+
+                /* Update machine for cloning finally: */
+                srcMachine = comCreatedSnapshot.GetMachine();
+            }
         }
 
         /* Unlock machine finally: */
         comSession.UnlockMachine();
-
-        /* Look for created snapshot: */
-        const CSnapshot comCreatedSnapshot = m_machine.FindSnapshot(uSnapshotId.toString());
-        if (comCreatedSnapshot.isNull())
-        {
-            msgCenter().cannotFindSnapshotByName(m_machine, strSnapshotName, this);
-            return false;
-        }
-
-        /* Update machine for cloning finally: */
-        srcMachine = comCreatedSnapshot.GetMachine();
     }