Changeset 90784 in vbox
- Timestamp:
- Aug 23, 2021 9:42:32 AM (3 years ago)
- Location:
- trunk/src/VBox/VMM
- Files:
-
- 14 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/src/VBox/VMM/VMMAll/PDMAllNetShaper.cpp
r90437 r90784 40 40 { 41 41 AssertPtrReturn(pFilter, true); 42 if (! VALID_PTR(pFilter->CTX_SUFF(pBwGroup)))42 if (!RT_VALID_PTR(pFilter->CTX_SUFF(pBwGroup))) 43 43 return true; 44 44 -
trunk/src/VBox/VMM/VMMAll/PDMAllQueue.cpp
r87766 r90784 45 45 VMMDECL(PPDMQUEUEITEMCORE) PDMQueueAlloc(PPDMQUEUE pQueue) 46 46 { 47 Assert( VALID_PTR(pQueue) && pQueue->CTX_SUFF(pVM));47 Assert(RT_VALID_PTR(pQueue) && pQueue->CTX_SUFF(pVM)); 48 48 PPDMQUEUEITEMCORE pNew; 49 49 uint32_t iNext; … … 92 92 VMMDECL(void) PDMQueueInsert(PPDMQUEUE pQueue, PPDMQUEUEITEMCORE pItem) 93 93 { 94 Assert( VALID_PTR(pQueue) && pQueue->CTX_SUFF(pVM));95 Assert (VALID_PTR(pItem));94 Assert(RT_VALID_PTR(pQueue) && pQueue->CTX_SUFF(pVM)); 95 AssertPtr(pItem); 96 96 97 97 #if 0 /* the paranoid android version: */ … … 159 159 VMMDECL(RCPTRTYPE(PPDMQUEUE)) PDMQueueRCPtr(PPDMQUEUE pQueue) 160 160 { 161 Assert (VALID_PTR(pQueue));161 AssertPtr(pQueue); 162 162 Assert(pQueue->pVMR3 && pQueue->pVMRC); 163 163 #ifdef IN_RC … … 178 178 VMMDECL(R0PTRTYPE(PPDMQUEUE)) PDMQueueR0Ptr(PPDMQUEUE pQueue) 179 179 { 180 Assert (VALID_PTR(pQueue));180 AssertPtr(pQueue); 181 181 Assert(pQueue->pVMR3 && pQueue->pVMR0); 182 182 #ifdef IN_RING0 -
trunk/src/VBox/VMM/VMMAll/PGMAll.cpp
r90439 r90784 3644 3644 size_t cch; 3645 3645 PGMRAMRANGE const *pRam = (PGMRAMRANGE const *)pvValue; 3646 if ( VALID_PTR(pRam))3646 if (RT_VALID_PTR(pRam)) 3647 3647 { 3648 3648 char szTmp[80]; -
trunk/src/VBox/VMM/VMMR0/GMMR0.cpp
r82992 r90784 933 933 */ 934 934 PGMM pGMM = g_pGMM; 935 if (! VALID_PTR(pGMM))935 if (!RT_VALID_PTR(pGMM)) 936 936 return; 937 937 if (pGMM->u32Magic != GMM_MAGIC) -
trunk/src/VBox/VMM/VMMR0/VMMR0.cpp
r90380 r90784 2701 2701 */ 2702 2702 PVMMR0LOGGER pR0Logger = (PVMMR0LOGGER)((uintptr_t)pLogger - RT_UOFFSETOF(VMMR0LOGGER, Logger)); 2703 if ( ! VALID_PTR(pR0Logger)2704 || ! VALID_PTR(pR0Logger + 1)2703 if ( !RT_VALID_PTR(pR0Logger) 2704 || !RT_VALID_PTR(pR0Logger + 1) 2705 2705 || pLogger->u32Magic != RTLOGGER_MAGIC) 2706 2706 { … … 2714 2714 2715 2715 PVMCC pVM = pR0Logger->pVM; 2716 if ( ! VALID_PTR(pVM)2716 if ( !RT_VALID_PTR(pVM) 2717 2717 || pVM->pSelf != pVM) 2718 2718 { -
trunk/src/VBox/VMM/VMMR3/DBGFAddr.cpp
r82968 r90784 210 210 { 211 211 UVM_ASSERT_VALID_EXT_RETURN(pUVM, false); 212 if (! VALID_PTR(pAddress))212 if (!RT_VALID_PTR(pAddress)) 213 213 return false; 214 214 if (!DBGFADDRESS_IS_VALID(pAddress)) -
trunk/src/VBox/VMM/VMMR3/DBGFMem.cpp
r85418 r90784 61 61 if (!DBGFR3AddrIsValid(pUVM, pAddress)) 62 62 return VERR_INVALID_POINTER; 63 if (! VALID_PTR(pHitAddress))63 if (!RT_VALID_PTR(pHitAddress)) 64 64 return VERR_INVALID_POINTER; 65 65 … … 155 155 if (!DBGFR3AddrIsValid(pUVM, pAddress)) 156 156 return VERR_INVALID_POINTER; 157 if (! VALID_PTR(pvBuf))157 if (!RT_VALID_PTR(pvBuf)) 158 158 return VERR_INVALID_POINTER; 159 159 … … 227 227 if (!DBGFR3AddrIsValid(pUVM, pAddress)) 228 228 return VERR_INVALID_POINTER; 229 if (! VALID_PTR(pszBuf))229 if (!RT_VALID_PTR(pszBuf)) 230 230 return VERR_INVALID_POINTER; 231 231 … … 273 273 * Validate and zero output. 274 274 */ 275 if (! VALID_PTR(pszBuf))275 if (!RT_VALID_PTR(pszBuf)) 276 276 return VERR_INVALID_POINTER; 277 277 if (cchBuf <= 0) … … 306 306 if (!DBGFR3AddrIsValid(pUVM, pAddress)) 307 307 return VERR_INVALID_POINTER; 308 if (! VALID_PTR(pvBuf))308 if (!RT_VALID_PTR(pvBuf)) 309 309 return VERR_INVALID_POINTER; 310 310 PVM pVM = pUVM->pVM; -
trunk/src/VBox/VMM/VMMR3/DBGFR3Flow.cpp
r88366 r90784 1336 1336 * @param fFlags Combination of DBGF_DISAS_FLAGS_*. 1337 1337 */ 1338 static int dbgfR3FlowPopulate(PUVM pUVM, VMCPUID idCpu, PDBGFFLOWINT pThis, 1339 uint32_t cbDisasmMax, uint32_t fFlags) 1338 static int dbgfR3FlowPopulate(PUVM pUVM, VMCPUID idCpu, PDBGFFLOWINT pThis, uint32_t cbDisasmMax, uint32_t fFlags) 1340 1339 { 1341 1340 int rc = VINF_SUCCESS; 1342 1341 PDBGFFLOWBBINT pFlowBb = dbgfR3FlowGetUnpopulatedBb(pThis); 1343 1342 1344 while ( VALID_PTR(pFlowBb))1343 while (pFlowBb != NULL) 1345 1344 { 1346 1345 rc = dbgfR3FlowBbProcess(pUVM, idCpu, pThis, pFlowBb, cbDisasmMax, fFlags); -
trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletion.cpp
r82968 r90784 1510 1510 1511 1511 /* Sanity checks. */ 1512 AssertReturnVoid( VALID_PTR(pEndpoint));1512 AssertReturnVoid(RT_VALID_PTR(pEndpoint)); 1513 1513 1514 1514 PPDMASYNCCOMPLETIONEPCLASS pEndpointClass = pEndpoint->pEpClass; -
trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletionFileFailsafe.cpp
r82968 r90784 191 191 { 192 192 PPDMASYNCCOMPLETIONENDPOINTFILE pEndpointNew = pAioMgr->BlockingEventData.AddEndpoint.pEndpoint; 193 AssertMsg( VALID_PTR(pEndpointNew), ("Adding endpoint event without a endpoint to add\n"));193 AssertMsg(RT_VALID_PTR(pEndpointNew), ("Adding endpoint event without a endpoint to add\n")); 194 194 195 195 pEndpointNew->enmState = PDMASYNCCOMPLETIONENDPOINTFILESTATE_ACTIVE; … … 214 214 { 215 215 PPDMASYNCCOMPLETIONENDPOINTFILE pEndpointRemove = pAioMgr->BlockingEventData.RemoveEndpoint.pEndpoint; 216 AssertMsg( VALID_PTR(pEndpointRemove), ("Removing endpoint event without a endpoint to remove\n"));216 AssertMsg(RT_VALID_PTR(pEndpointRemove), ("Removing endpoint event without a endpoint to remove\n")); 217 217 218 218 pEndpointRemove->enmState = PDMASYNCCOMPLETIONENDPOINTFILESTATE_REMOVING; … … 235 235 { 236 236 PPDMASYNCCOMPLETIONENDPOINTFILE pEndpointClose = pAioMgr->BlockingEventData.CloseEndpoint.pEndpoint; 237 AssertMsg( VALID_PTR(pEndpointClose), ("Close endpoint event without a endpoint to Close\n"));237 AssertMsg(RT_VALID_PTR(pEndpointClose), ("Close endpoint event without a endpoint to Close\n")); 238 238 239 239 pEndpointClose->enmState = PDMASYNCCOMPLETIONENDPOINTFILESTATE_CLOSING; -
trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletionFileNormal.cpp
r82968 r90784 1004 1004 pCurr->pNext = NULL; 1005 1005 1006 AssertMsg( VALID_PTR(pCurr->pEndpoint) && (pCurr->pEndpoint == pEndpoint),1006 AssertMsg(RT_VALID_PTR(pCurr->pEndpoint) && pCurr->pEndpoint == pEndpoint, 1007 1007 ("Endpoints do not match\n")); 1008 1008 … … 1198 1198 { 1199 1199 PPDMASYNCCOMPLETIONENDPOINTFILE pEndpointNew = ASMAtomicReadPtrT(&pAioMgr->BlockingEventData.AddEndpoint.pEndpoint, PPDMASYNCCOMPLETIONENDPOINTFILE); 1200 AssertMsg( VALID_PTR(pEndpointNew), ("Adding endpoint event without a endpoint to add\n"));1200 AssertMsg(RT_VALID_PTR(pEndpointNew), ("Adding endpoint event without a endpoint to add\n")); 1201 1201 1202 1202 pEndpointNew->enmState = PDMASYNCCOMPLETIONENDPOINTFILESTATE_ACTIVE; … … 1217 1217 { 1218 1218 PPDMASYNCCOMPLETIONENDPOINTFILE pEndpointRemove = ASMAtomicReadPtrT(&pAioMgr->BlockingEventData.RemoveEndpoint.pEndpoint, PPDMASYNCCOMPLETIONENDPOINTFILE); 1219 AssertMsg( VALID_PTR(pEndpointRemove), ("Removing endpoint event without a endpoint to remove\n"));1219 AssertMsg(RT_VALID_PTR(pEndpointRemove), ("Removing endpoint event without a endpoint to remove\n")); 1220 1220 1221 1221 pEndpointRemove->enmState = PDMASYNCCOMPLETIONENDPOINTFILESTATE_REMOVING; … … 1226 1226 { 1227 1227 PPDMASYNCCOMPLETIONENDPOINTFILE pEndpointClose = ASMAtomicReadPtrT(&pAioMgr->BlockingEventData.CloseEndpoint.pEndpoint, PPDMASYNCCOMPLETIONENDPOINTFILE); 1228 AssertMsg( VALID_PTR(pEndpointClose), ("Close endpoint event without a endpoint to close\n"));1228 AssertMsg(RT_VALID_PTR(pEndpointClose), ("Close endpoint event without a endpoint to close\n")); 1229 1229 1230 1230 if (pEndpointClose->enmState == PDMASYNCCOMPLETIONENDPOINTFILESTATE_ACTIVE) -
trunk/src/VBox/VMM/VMMR3/PDMDriver.cpp
r90348 r90784 286 286 ("%s: %.*s\n", pReg->szName, sizeof(pReg->szRCMod), pReg->szRCMod), 287 287 VERR_PDM_INVALID_DRIVER_REGISTRATION); 288 AssertMsgReturn( VALID_PTR(pReg->pszDescription),288 AssertMsgReturn(RT_VALID_PTR(pReg->pszDescription), 289 289 ("%s: %p\n", pReg->szName, pReg->pszDescription), 290 290 VERR_PDM_INVALID_DRIVER_REGISTRATION); … … 301 301 ("%s: %#x\n", pReg->szName, pReg->cbInstance), 302 302 VERR_PDM_INVALID_DRIVER_REGISTRATION); 303 AssertMsgReturn( VALID_PTR(pReg->pfnConstruct),303 AssertMsgReturn(RT_VALID_PTR(pReg->pfnConstruct), 304 304 ("%s: %p\n", pReg->szName, pReg->pfnConstruct), 305 305 VERR_PDM_INVALID_DRIVER_REGISTRATION); 306 AssertMsgReturn( VALID_PTR(pReg->pfnRelocate) || !(pReg->fFlags & PDM_DRVREG_FLAGS_RC),306 AssertMsgReturn(RT_VALID_PTR(pReg->pfnRelocate) || !(pReg->fFlags & PDM_DRVREG_FLAGS_RC), 307 307 ("%s: %#x\n", pReg->szName, pReg->cbInstance), 308 308 VERR_PDM_INVALID_DRIVER_REGISTRATION); -
trunk/src/VBox/VMM/VMMR3/VMEmt.cpp
r88346 r90784 75 75 RT_NOREF_PV(hThreadSelf); 76 76 77 AssertReleaseMsg( VALID_PTR(pUVM) && pUVM->u32Magic == UVM_MAGIC,77 AssertReleaseMsg(RT_VALID_PTR(pUVM) && pUVM->u32Magic == UVM_MAGIC, 78 78 ("Invalid arguments to the emulation thread!\n")); 79 79 -
trunk/src/VBox/VMM/VMMR3/VMReq.cpp
r85121 r90784 811 811 */ 812 812 AssertMsgReturn(pReq->enmState == VMREQSTATE_ALLOCATED, ("%d\n", pReq->enmState), VERR_VM_REQUEST_STATE); 813 AssertMsgReturn( VALID_PTR(pReq->pUVM)813 AssertMsgReturn( RT_VALID_PTR(pReq->pUVM) 814 814 && !pReq->pNext 815 815 && pReq->EventSem != NIL_RTSEMEVENT, … … 970 970 ("Invalid state %d\n", pReq->enmState), 971 971 VERR_VM_REQUEST_STATE); 972 AssertMsgReturn( VALID_PTR(pReq->pUVM)972 AssertMsgReturn( RT_VALID_PTR(pReq->pUVM) 973 973 && pReq->EventSem != NIL_RTSEMEVENT, 974 974 ("Invalid request package! Anyone cooking their own packages???\n"),
Note:
See TracChangeset
for help on using the changeset viewer.