Changeset 90887 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Aug 25, 2021 4:20:14 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146523

Message:

Audio/VKAT: More code for TCP/IP connection mode handling; don't do things less implicitly but let the caller (or rather test driver) choose how to connect to the guest/host instead. ​bugref:10008

Location:

trunk/src/VBox/Devices/Audio

Files:

• AudioTestServiceClient.cpp (modified) (1 diff)
• AudioTestServiceTcp.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/AudioTestServiceClient.cpp

@@ -513 +513 @@
 static int audioTestSvcClientCloseInternal(PATSCLIENT pClient)
 {
+    if (!pClient->pTransportClient) /* Not connected (yet)? Bail out early. */
+        return VINF_SUCCESS;
+
     int rc = audioTestSvcClientDoBye(pClient);
     if (RT_SUCCESS(rc))

trunk/src/VBox/Devices/Audio/AudioTestServiceTcp.cpp

@@ -786 +786 @@
             if (RT_FAILURE(rc))
                 return RTMsgErrorRc(VERR_INVALID_PARAMETER, "TCP bind address is too long (%Rrc)", rc);
+            if (!pThis->szBindAddr[0])
+                return RTMsgErrorRc(VERR_INVALID_PARAMETER, "No TCP bind address specified: %s", pThis->szBindAddr);
             return VINF_SUCCESS;
 
         case ATSTCPOPT_BIND_PORT:
-            pThis->uBindPort = pVal->u16 == 0 ? ATS_TCP_DEF_BIND_PORT_GUEST : pVal->u16;
+            pThis->uBindPort = pVal->u16;
             return VINF_SUCCESS;
 
@@ -797 +799 @@
                 return RTMsgErrorRc(VERR_INVALID_PARAMETER, "TCP connect address is too long (%Rrc)", rc);
             if (!pThis->szConnectAddr[0])
-                strcpy(pThis->szConnectAddr, ATS_TCP_DEF_CONNECT_GUEST_STR);
+                return RTMsgErrorRc(VERR_INVALID_PARAMETER, "No TCP connect address specified");
             return VINF_SUCCESS;
 
         case ATSTCPOPT_CONNECT_PORT:
-            pThis->uConnectPort = pVal->u16 == 0 ? ATS_TCP_DEF_BIND_PORT_GUEST : pVal->u16;
+            pThis->uConnectPort = pVal->u16;
             return VINF_SUCCESS;