Changeset 90954 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Aug 27, 2021 1:25:40 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146593

Message:

Audio/Validation Kit: Log VERR_NET_PROTOCOL_ERROR errors to shed some light on the failing test boxes. ​bugref:10008

Location:

trunk/src/VBox/Devices/Audio

Files:

• AudioTestServiceClient.cpp (modified) (3 diffs)
• AudioTestServiceTcp.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/AudioTestServiceClient.cpp

@@ -109 +109 @@
     if (RT_SUCCESS(rc))
     {
-        AssertReturn(pPktHdr->cb >= sizeof(ATSPKTHDR), VERR_NET_PROTOCOL_ERROR);
+        AssertReleaseMsgReturn(pPktHdr->cb >= sizeof(ATSPKTHDR),
+                               ("audioTestSvcClientRecvReply: Received invalid packet size (%RU32)\n", pPktHdr->cb),
+                               VERR_NET_PROTOCOL_ERROR);
         pReply->cbPayload = pPktHdr->cb - sizeof(ATSPKTHDR);
         Log3Func(("szOp=%.8s, cb=%RU32\n", pPktHdr->achOpcode, pPktHdr->cb));
@@ -122 +124 @@
             && !fNoDataOk)
         {
+            LogRelFunc(("Payload is empty (%zu), but caller expected data\n", pReply->cbPayload));
             rc = VERR_NET_PROTOCOL_ERROR;
         }
@@ -153 +156 @@
     {
         if (RTStrNCmp(Reply.szOp, "ACK     ", ATSPKT_OPCODE_MAX_LEN) != 0)
+        {
+            LogRelFunc(("Received invalid ACK opcode ('%.8s')\n", Reply.szOp));
             rc = VERR_NET_PROTOCOL_ERROR;
+        }
 
         audioTestSvcClientReplyDestroy(&Reply);

trunk/src/VBox/Devices/Audio/AudioTestServiceTcp.cpp

@@ -594 +594 @@
         }
         else
+        {
+            LogRelFunc(("Received invalid packet size (%zu)\n", cbData));
             rc = VERR_NET_PROTOCOL_ERROR;
+        }
     }
     if (RT_SUCCESS(rc))