Changeset 91023 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Aug 31, 2021 9:25:10 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

146664

Message:

Audio/Validation Kit: More (verbose) releasing logging. ​bugref:10008

Location:

trunk/src/VBox/Devices/Audio

Files:

• AudioTestService.cpp (modified) (8 diffs)
• AudioTestServiceTcp.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Audio/AudioTestService.cpp

@@ -988 +988 @@
     RT_NOREF(hThread);
 
+    LogRelFlowFuncEnter();
+
     PATSSERVER pThis = (PATSSERVER)pvUser;
     AssertPtrReturn(pThis, VERR_INVALID_POINTER);
@@ -1024 +1026 @@
             rc = RTPipeWrite(pThis->hPipeW, "", 1, &cbWritten);
             if (RT_FAILURE(rc))
-                LogRel(("Failed to inform worker thread of a new client, rc=%Rrc\n", rc));
+                LogRelFunc(("Failed to inform worker thread of a new client, rc=%Rrc\n", rc));
         }
         else
         {
-            LogRel(("Creating new client structure failed with out of memory error\n"));
+            LogRelFunc(("Creating new client structure failed with out of memory error\n"));
             pThis->pTransport->pfnNotifyBye(pThis->pTransportInst, pTransportClient);
         }
     }
 
+    LogRelFlowFuncLeaveRC(rc);
     return rc;
 }
@@ -1121 +1124 @@
 int AudioTestSvcStart(PATSSERVER pThis)
 {
+    LogRelFlowFuncEnter();
+
     /* Spin off the thread serving connections. */
     int rc = RTThreadCreate(&pThis->hThreadServing, atsClientWorker, pThis, 0, RTTHREADTYPE_IO, RTTHREADFLAGS_WAITABLE,
@@ -1144 +1149 @@
     }
 
+    LogRelFlowFuncLeaveRC(rc);
     return rc;
 }
@@ -1157 +1163 @@
     if (!pThis->fStarted)
         return VINF_SUCCESS;
+
+    LogRelFlowFuncEnter();
 
     ASMAtomicXchgBool(&pThis->fTerminate, true);
@@ -1188 +1196 @@
         pThis->fStarted = false;
 
+    LogRelFlowFuncLeaveRC(rc);
     return rc;
 }
@@ -1244 +1253 @@
 int AudioTestSvcDestroy(PATSSERVER pThis)
 {
+    LogRelFlowFuncEnter();
+
     int rc = audioTestSvcDestroyInternal(pThis);
     if (RT_SUCCESS(rc))
@@ -1258 +1269 @@
     }
 
-    return rc;
-}
+    LogRelFlowFuncLeaveRC(rc);
+    return rc;
+}

trunk/src/VBox/Devices/Audio/AudioTestServiceTcp.cpp

@@ -131 +131 @@
     if (pClient->hTcpClient != NIL_RTSOCKET)
     {
-        LogRelFlowFunc(("Disconnecting client %RTsock\n", pClient->hTcpClient));
+        LogRelFlowFunc(("%RTsock\n", pClient->hTcpClient));
 
         int rc;
@@ -347 +347 @@
             LogRelFlowFunc(("Calling RTTcpClientConnect(%s, %u,)...\n", pThis->szConnectAddr, pThis->uConnectPort));
             rc = RTTcpClientConnect(pThis->szConnectAddr, pThis->uConnectPort, &pClient->hTcpClient);
-            LogRelFlowFunc(("RTTcpClientConnect -> %Rrc\n", rc));
+            LogRelFlowFunc(("RTTcpClientConnect(%RTsock) -> %Rrc\n", pClient->hTcpClient, rc));
             if (RT_SUCCESS(rc) || atsTcpIsFatalClientConnectStatus(rc))
                 break;
@@ -463 +463 @@
 static DECLCALLBACK(void) atsTcpNotifyBye(PATSTRANSPORTINST pThis, PATSTRANSPORTCLIENT pClient)
 {
-    LogFunc(("atsTcpDisconnectClient %RTsock\n", pClient->hTcpClient));
+    LogRelFunc(("%RTsock\n", pClient->hTcpClient));
     atsTcpDisconnectClient(pThis, pClient);
 }
@@ -472 +472 @@
 static DECLCALLBACK(void) atsTcpNotifyHowdy(PATSTRANSPORTINST pThis, PATSTRANSPORTCLIENT pClient)
 {
+    LogRelFunc(("%RTsock\n", pClient->hTcpClient));
+
     /* nothing to do here */
-    RT_NOREF(pThis, pClient);
+    RT_NOREF(pThis);
 }
 
@@ -511 +513 @@
     Log3Func(("%RU32 -> %zu\n", pPktHdr->cb, cbToSend));
 
+    LogRelFlowFunc(("%RTsock\n", pClient->hTcpClient));
     LogRelFlowFunc(("Header:\n"
                     "%.*Rhxd\n", RT_MIN(sizeof(ATSPKTHDR), cbToSend), pPktHdr));
@@ -538 +541 @@
     int rc = VINF_SUCCESS;
     *ppPktHdr = NULL;
+
+    LogRelFlowFunc(("%RTsock\n", pClient->hTcpClient));
 
     /*